From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 22ADD589F42; Tue, 15 Aug 2023 16:21:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 22ADD589F42 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1692105709; bh=sxNHXo2sWCuKjOu8hwVfbAQt+IDfloHKL1Vk0Ta9uT8=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=bIi4UZpRl1Sk+dHukMawxrmAiQ6+EnlNXGeer7nIOZ2JsQU1M6aPhMax5T3HQKxWW zZmlD/Zcg4zQUBAMRyVBzIu/mYXYI1bMfz1I7Mp5HepxDLWDEAHBBDJRa+C2cQscW+ GfFH1EeMq4/kblBtJWM0VL4+UaVn2srhvSCjUuuU= Received: from smtp35.i.mail.ru (smtp35.i.mail.ru [95.163.41.76]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0477A589F42 for ; Tue, 15 Aug 2023 16:21:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0477A589F42 Received: by smtp35.i.mail.ru with esmtpa (envelope-from ) id 1qVtzX-005Wta-0i; Tue, 15 Aug 2023 16:21:47 +0300 Date: Tue, 15 Aug 2023 16:21:46 +0300 To: Sergey Kaplun Message-ID: References: <08708e70d731d2f0ac7d30399888f5620d06df16.1691592488.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <08708e70d731d2f0ac7d30399888f5620d06df16.1691592488.git.skaplun@tarantool.org> X-Mailru-Src: smtp X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD969E04B5EED670DC86EE92E42F0C271DDDF6A6B73F41FC074182A05F5380850401D84B814539CE70EADAAA3C3C706994728BFF03480528808F68109B3D8ECD332 X-C1DE0DAB: 0D63561A33F958A57AA8510161FC48D31E575B0ABD690D4C0BABD00E7652D4A8F87CCE6106E1FC07E67D4AC08A07B9B013BDA61BF53F5E1DCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0AD5177F0B940C8B66ECE892A7B2722663E91682638B966EB3F662256BEEFA9527FE2DDD04C58AC763116306D03F7A43C871F7471051B61C28E6F2BC24D4952B28D6954FB57DB3D4A7937FD76D11AF80A0D92801D5A6536D8B74CDF5A6ECBA3D031EA455F16B58544A21C197AAF4D2E4732965026E5D17F6739C77C69D99B9914278E50E1F0597A6FD5CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojHVl7ekwB6hg9GHv09Lk7BA== X-Mailru-Sender: 11C2EC085EDE56FA38FD4C59F7EFE40782AF82BFD72E75B0F463EC42F643652A02DB2107894D0CA5D51284F0FE6F529ABC7555A253F5B200DF104D74F62EE79D27EC13EC74F6107F4198E0F3ECE9B5443453F38A29522196 X-Mras: OK Subject: Re: [Tarantool-patches] [PATCH luajit 12/19] DynASM: Fix warning. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Maxim Kokryashkin via Tarantool-patches Reply-To: Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the patch! LGTM as trivial, except for the single comment regarding the commit message below. On Wed, Aug 09, 2023 at 06:36:01PM +0300, Sergey Kaplun via Tarantool-patches wrote: > From: Mike Pall > > (cherry-picked from commit 9b41062156779160b88fe5e1eb1ece1ee1fe6a74) > > This patch adds the `/* fallthrough */` comments elsewhere, where it was > missing for the ARM64 build, so the `-Wimplicit-fallthrough` [1] warning > is trigerred. Since there are no 'comments', but the single 'comment', I believe a better phrasing would be: | This patch adds the `/* fallthrough */` comment to dynasm/dasm_arm64.h, so the | `-Wimplicit-fallthrough` [1] warning is not trigerred anymore for the ARM64 build. > > [1]: https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-fallthrough > > Sergey Kaplun: > * added the description for the commit > > Part of tarantool/tarantool#8825 > --- > dynasm/dasm_arm64.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/dynasm/dasm_arm64.h b/dynasm/dasm_arm64.h > index 47e1e074..ff21236d 100644 > --- a/dynasm/dasm_arm64.h > +++ b/dynasm/dasm_arm64.h > @@ -427,6 +427,7 @@ int dasm_encode(Dst_DECL, void *buffer) > break; > case DASM_REL_LG: > CK(n >= 0, UNDEF_LG); > + /* fallthrough */ > case DASM_REL_PC: > CK(n >= 0, UNDEF_PC); > n = *DASM_POS2PTR(D, n) - (int)((char *)cp - base) + 4; > -- > 2.41.0 >