From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id C85E7554FC7; Sun, 26 May 2024 12:50:06 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C85E7554FC7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1716717006; bh=ywCEhDniqYz1Br/YCoR+T0Dd/FTTg+LSPvUBXFY36NY=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=qrbaseLLCqbW7oHiGlbWcW4o3iuBqGe9KQb2EqrHP3OsFuz8APfzLjWQvhcU2t54v IoxfgnKLDhwPlubUbigunTSv2HnABlHu/5Iuq4ft94M3f/arH8swIxh5KUunDKSJXU aGt/KG6iHvWfkIuYnJT4LCGs0x7AN9U0TWOxyPe4= Received: from smtp39.i.mail.ru (smtp39.i.mail.ru [95.163.41.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id BD420554FC7 for ; Sun, 26 May 2024 12:50:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BD420554FC7 Received: by smtp39.i.mail.ru with esmtpa (envelope-from ) id 1sBAVw-0000000BEfJ-1Lmu; Sun, 26 May 2024 12:50:04 +0300 Date: Sun, 26 May 2024 12:50:03 +0300 To: Sergey Kaplun Message-ID: References: <8d8b6798b2a52f868c7b6b6d1c56d07ae8d20fdd.1715776117.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8d8b6798b2a52f868c7b6b6d1c56d07ae8d20fdd.1715776117.git.skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD99EF2330544E8CB053D8C077A2C70D1E00D7C0EBD42C87DF8182A05F5380850405A678C5A5FFE351433594132A326AF8B420002D3A6DF04F655B56C2227878800261E30AE1A3D86FE X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7798B95EC47D21699EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637B28E90C11C329EF18638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8CFF7F44085824B290AA6E1C164E2C6DF83149789306B63D4CC7F00164DA146DAFE8445B8C89999728AA50765F79006375FFD5C25497261569FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C34964A708C60C975A117882F4460429728AD0CFFFB425014E868A13BD56FB6657D81D268191BDAD3DC09775C1D3CA48CF25C33BDE98D8A053BA3038C0950A5D36C8A9BA7A39EFB766D91E3A1F190DE8FDBA3038C0950A5D36D5E8D9A59859A8B6455B07CE27F2DB4F76E601842F6C81A1F004C906525384303E02D724532EE2C3F43C7A68FF6260569E8FC8737B5C2249D082881546D93491E827F84554CEF50127C277FBC8AE2E8BF1175FABE1C0F9B6AAAE862A0553A39223F8577A6DFFEA7CA5583D5FF21A78E543847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A5D81B9FA4A28B4F3A5002B1117B3ED69656D99411D1605DABC81EEE05487B0209823CB91A9FED034534781492E4B8EEADA2D5570B22232E1EBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFC3451C4F84CFEB1FE108A38B794A34AFCDBF5BBE88CA9CFA8EC5EDDC46A0AEF1FA91ADFD12D7A65BF62F9ADBD0A65E4DFAFCE2D9B57FF48E7FDC281A797924055968691777FF67095F4332CA8FE04980913E6812662D5F2A54F6898A6FDCBDC72A617DFBE5FEC2C6383653B6C8D9AE0FD16FCAA6493B703A X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojnJlDmFYFlmFG1voDaK0XHQ== X-Mailru-Sender: 00097D31F91C944B27477D5EE6B524EB0FDA8B2DA2D260FADF237C39DF130474F9470140824634D3D90DE200B9E4C2F6D51284F0FE6F529ABC7555A253F5B200DF104D74F62EE79D27EC13EC74F6107F4198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/2] ci: enable UBSan for sanitizers testing workflow X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Maxim Kokryashkin via Tarantool-patches Reply-To: Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the patch! LGTM, except for the single nit below. On Wed, May 15, 2024 at 03:32:01PM UTC, Sergey Kaplun wrote: > Relates to tarantool/tarantool#8473 > --- > .github/workflows/sanitizers-testing.yml | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/.github/workflows/sanitizers-testing.yml b/.github/workflows/sanitizers-testing.yml > index 154ebe40..4bf7d023 100644 > --- a/.github/workflows/sanitizers-testing.yml > +++ b/.github/workflows/sanitizers-testing.yml > @@ -41,7 +41,7 @@ jobs: > CMAKEFLAGS: -DCMAKE_BUILD_TYPE=RelWithDebInfo > runs-on: [self-hosted, regular, Linux, x86_64] > name: > > - LuaJIT with ASan (Linux/x86_64) > + LuaJIT with ASan and UBSan (Linux/x86_64) > ${{ matrix.BUILDTYPE }} > CC:${{ matrix.CC }} > GC64:ON SYSMALLOC:ON > @@ -70,9 +70,10 @@ jobs: > cmake -S . -B ${{ env.BUILDDIR }} > -G Ninja > ${{ matrix.CMAKEFLAGS }} > + -DLUAJIT_ENABLE_GC64=ON I see why this change was made, but it is irrelevant to the patch. The decision to leave it as it is or remove is up to you. > -DLUAJIT_USE_ASAN=ON > -DLUAJIT_USE_SYSMALLOC=ON > - -DLUAJIT_ENABLE_GC64=ON > + -DLUAJIT_USE_UBSAN=ON > - name: build > run: cmake --build . --parallel > working-directory: ${{ env.BUILDDIR }} > @@ -91,5 +92,8 @@ jobs: > symbolize=1: \ > unmap_shadow_on_exit=1: \ > " > + UBSAN_OPTIONS: " > + print_stacktrace=1 \ > + " > run: cmake --build . --parallel --target LuaJIT-test > working-directory: ${{ env.BUILDDIR }} > -- > 2.45.0 >