From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 06AC95A9F2A; Mon, 4 Sep 2023 08:45:02 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 06AC95A9F2A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1693806302; bh=OYua22uUPZSisp45QvhBnHW3GPm63cM8AjZXECuERr4=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=uvq1wVHmqUWNKtBmE1huM+3ekYxzOhdS+gYk69LWgLJ11ja4iKs9lGTkpXbWR/4K2 JjNbseT3BP8xN7J7cYXTXWonwub+h0/p/MAGP1LsUqk7JdLWioTZ1KeXgc8SprCtuI YXiLAKLI4ygoJaKtP228XwRf+KFxIqkwNzy7638U= Received: from smtp31.i.mail.ru (smtp31.i.mail.ru [95.163.41.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9298E54E3C1 for ; Mon, 4 Sep 2023 08:45:00 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9298E54E3C1 Received: by smtp31.i.mail.ru with esmtpa (envelope-from ) id 1qd2OR-00ErS1-11; Mon, 04 Sep 2023 08:44:59 +0300 Date: Mon, 4 Sep 2023 08:44:58 +0300 To: Sergey Kaplun Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD96E142CFC92DB15CD43B17B8DE4233CAE5689C6DEE55D6799182A05F538085040831109A15EC72983675A85E1BB6A56F4FADA5F7EDAD9172B5F5E9D257EA1DA53 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE77AA33865E80AF043EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AD1E1BF10F09609D8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D839670A9C2D50D4826591135C38311371117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC972D20C7389F068BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD186FD1C55BDD38FC3FD2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EEB1593CA6EC85F86DFCE65BE3358055BDD8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE3457EE4B4996FC54603F1AB874ED89028C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637B8F435DEDE9E76EBEFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5D727C7C480D2AEDF5C13793B56677BA4FC72FAD20FC545BAF87CCE6106E1FC07E67D4AC08A07B9B0CE135D2742255B35CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF1F2FE4E38A257B1932F93CE785C9241DF9A05757675EB1378E4D8D130320B8EC614F3626C4CAF433EA61C66FA002EE27EC25A682301D5755E371400F35365A75A74DFFEFA5DC0E7F02C26D483E81D6BE64ACE4A408B72B61B0CA6F94E606A667A52EF62A646584F811BD90D3D42C882D43082AE146A756F3 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojNmsqR+t6vc+csWTJ4PRuwA== X-Mailru-Sender: 7940E2A4EB16C9975791D6D34F6B5B9E4D9C14BA511030F201CDB4B8E746D85BE2527C969975515CFF9FCECFB8D89CB6C77752E0C033A69E235A20A81F3B0E39AB3C5F247CB2F7F93A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/2] memprof: refactor symbol resolution X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Maxim Kokryashkin via Tarantool-patches Reply-To: Maxim Kokryashkin Cc: Maxim Kokryashkin , tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Fixed your comment, the branch is force pushed. On Sun, Sep 03, 2023 at 01:14:37PM +0300, Sergey Kaplun wrote: > Hi, Maxim! > Thanks for the patch! > LGTM, with a minor nit below. > > On 28.08.23, Maxim Kokryashkin wrote: > > This patch refactors symbol resolution in memprof, so > > now they are resolved during the process of parsing. > > This makes the generation mechanism excessive since > > symtab updates are no longer affecting the previous events. > > > > Follows up tarantool/tarantool#8700 > > --- > > .../misclib-memprof-lapi.test.lua | 73 +++++-------------- > > tools/memprof/humanize.lua | 16 ++-- > > tools/memprof/parse.lua | 2 +- > > tools/memprof/process.lua | 8 +- > > 4 files changed, 31 insertions(+), 68 deletions(-) > > > > diff --git a/test/tarantool-tests/misclib-memprof-lapi.test.lua b/test/tarantool-tests/misclib-memprof-lapi.test.lua > > index 3cb5c8be..0eee4e21 100644 > > --- a/test/tarantool-tests/misclib-memprof-lapi.test.lua > > +++ b/test/tarantool-tests/misclib-memprof-lapi.test.lua > > > > > @@ -86,44 +86,13 @@ local function form_source_line(line, source) > > end > > > > local function form_trace_line(traceno, line, source) > > - return ("TRACE [%d] %s:%d"):format(traceno, source or SRC_PATH, line) > > + return ("TRACE [%d] started at %s:%d"):format(traceno, source or SRC_PATH, line) > > Nit: Line width is more than 80 symbols. Here is the diff: ========================================================================== diff --git a/test/tarantool-tests/misclib-memprof-lapi.test.lua b/test/tarantool-tests/misclib-memprof-lapi.test.lua index 0eee4e21..b97462a5 100644 --- a/test/tarantool-tests/misclib-memprof-lapi.test.lua +++ b/test/tarantool-tests/misclib-memprof-lapi.test.lua @@ -86,7 +86,11 @@ local function form_source_line(line, source) end local function form_trace_line(traceno, line, source) - return ("TRACE [%d] started at %s:%d"):format(traceno, source or SRC_PATH, line) + return ("TRACE [%d] started at %s:%d"):format( + traceno, + source or SRC_PATH, + line + ) end local function fill_ev_type(events, event_type) ========================================================================== > > > end > > > > -local function fill_ev_type(events, symbols, event_type) > > > > > diff --git a/tools/memprof/humanize.lua b/tools/memprof/humanize.lua > > index 267baa91..5b289ce3 100644 > > --- a/tools/memprof/humanize.lua > > +++ b/tools/memprof/humanize.lua > > > > > diff --git a/tools/memprof/parse.lua b/tools/memprof/parse.lua > > index d865267b..1b6eceb4 100644 > > --- a/tools/memprof/parse.lua > > +++ b/tools/memprof/parse.lua > > > > > diff --git a/tools/memprof/process.lua b/tools/memprof/process.lua > > index 0bcb965b..faf4be4e 100644 > > --- a/tools/memprof/process.lua > > +++ b/tools/memprof/process.lua > > > > > -- > > 2.41.0 > > > > -- > Best regards, > Sergey Kaplun