From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E83FFDD8205; Mon, 23 Dec 2024 10:43:45 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E83FFDD8205 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1734939826; bh=toEpP9m5HnvbtR5GFl+LsLt8G+wGk3zHj89PE84dZkk=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=w0QJKRrBR8DteliHeCDQnJiXn41dafbBpAj8Pv32WSFwvf3lsSqm1NnKURtStyJ8D apXMqnCd1R+kkMz66pJjhEe5NKFrVsejXYMgB8mIAAeCrpiCcBcD4Ddk2Z/WUY9onV T8FMYkHWvxuLjgUMtlQSyx6JmLK2LUy9UvMAQqbQ= Received: from send266.i.mail.ru (send266.i.mail.ru [95.163.59.105]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 65C8C43ED46 for ; Mon, 23 Dec 2024 10:43:44 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 65C8C43ED46 Received: by exim-smtp-cc4f974bf-nlw9m with esmtpa (envelope-from ) id 1tPd6K-000000000kt-0oSf; Mon, 23 Dec 2024 10:43:40 +0300 Date: Mon, 23 Dec 2024 10:43:09 +0300 To: Sergey Kaplun Message-ID: References: <20241219093041.14681-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241219093041.14681-1-skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD90D1D1AB5450899815CAE1582B24C296D611165901D3B4C36182A05F538085040006C718408E3ADDD3DE06ABAFEAF670524A079E52287A30226CCA24D42E87C1EA073804FB877F3AD X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7544B1CCE26E01C74EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637E25DEE08FA4D750E8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D82E2D97917AEC3FC328809755AE92C733A3C8563486D4A61CCC7F00164DA146DAFE8445B8C89999728AA50765F7900637D0FEED2715E18529389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC81D471462564A2E19F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947CAD74539164518AE52D242C3BD2E3F4C64AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C3E6DA32D78056113CBA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CFED8438A78DFE0A9E1DD303D21008E298D5E8D9A59859A8B64854413538E1713F75ECD9A6C639B01B78DA827A17800CE7C7AF014947417506731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A5072E04454A56AECA5002B1117B3ED6960A26CEC73C48EFBE3D2BBC1EF78EDEBE823CB91A9FED034534781492E4B8EEADB1D70E2111C441FFBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D3480665FBD8F49180C0EEC32F049A124786EE3F12AC995C3F9B678AD5795CFB6193F65365270DF72241D7E09C32AA3244C13630E216152601477DD89D51EBB7742E271749FB902DB0CEA455F16B58544A2557BDE0DD54B3590965026E5D17F6739C77C69D99B9914278E50E1F0597A6FD5CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojXozcCdatr+B6fhvdBwdMwQ== X-Mailru-Sender: 7940E2A4EB16C997CC5935E525FB1C36BF35C9CF591498B43DE06ABAFEAF6705FD6E588FAD81DA54B6F7D78CE1F58EAD61AD1BC23DFB21333DDE9B364B0DF289BB83A8C3DAEBA78A61AAEF30F77CACB9EAB4BC95F72C04283CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] test: harden skipcond for libc in LuaJIT-tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Maxim Kokryashkin via Tarantool-patches Reply-To: Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the patch! LGTM, except for the single nit below. On Thu, Dec 19, 2024 at 12:30:41PM +0300, Sergey Kaplun wrote: > The `strtod parsing` subtest in the checks > the results yielded by the `strtod()` via FFI call. In glibc versions > before 2.28 it returns an incorrect result (NaN instead of inf) for > "0x3p1023" [1]. This patch hardens the skipcond for this test for a > smaller version of the libc installed. I believe these versions are usually referred to as `older`, not `smaller`. Feel free to ignore. Side note: I agree with Sergey Bronnikov here, we should really try and push the operating systems that have reached their EOL out of our CI, so we can focus on something that matters. > > [1]: https://sourceware.org/bugzilla/show_bug.cgi?id=23279 > --- > > Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-noticket-fix-glibc-versions > > The CI failure for libc 2.23 (ubuntu 16): > https://github.com/tarantool/tarantool/actions/runs/12376159316/job/34542626889?pr=10949#step:5:13916 > The CI failure for libc 2.24 (debian 9): > https://github.com/tarantool/tarantool/actions/runs/12376159307/job/34542633454?pr=10949#step:5:13859 > The CI failure for libc 2.27 (ubuntu 18): > https://github.com/tarantool/tarantool/actions/runs/12376159278/job/34542625496?pr=10949#step:5:11743 > The CI pass for libc 2.31 (ubuntu 20): > https://github.com/tarantool/tarantool/actions/runs/12376159289/job/34542630993?pr=10949 > > test/LuaJIT-tests/lib/base/tonumber_scan.lua | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/test/LuaJIT-tests/lib/base/tonumber_scan.lua b/test/LuaJIT-tests/lib/base/tonumber_scan.lua > index ac7d68a4..800c57b0 100644 > --- a/test/LuaJIT-tests/lib/base/tonumber_scan.lua > +++ b/test/LuaJIT-tests/lib/base/tonumber_scan.lua > @@ -186,9 +186,11 @@ do --- tonumber parsing > test_conv(tonumber) > end > > --- Skip for the old libc version with the bug in the `strtod()`. > --- See also https://sourceware.org/bugzilla/show_bug.cgi?id=16151. > -do --- strtod parsing -libc<2.19 > +-- Skip for the old libc version with the bugs in the `strtod()`. > +-- Affected versions: > +-- * <2.19: https://sourceware.org/bugzilla/show_bug.cgi?id=16151. > +-- * <2.28: https://sourceware.org/bugzilla/show_bug.cgi?id=23279. > +do --- strtod parsing -libc<2.28 > test_conv(function(s) > local d = ffi.C.strtod(s, e) > return (e[0][0] == 0 and #s ~= 0) and d or nil > -- > 2.47.0 >