From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 108697511B6; Tue, 9 Jan 2024 17:18:27 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 108697511B6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1704809907; bh=9wZSWT6mln06ghwzK9l3ok5BYVX2XeGxl3HIgDaSDAE=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=zD5/G51F6cqs68aDUbELjcCJPaaFwxAEiiOD9/tzxF8yLU5Fe4jaDa89k7q5UKgkF GEtrPPwnzZRh8gH4ab07JEtJyfai+FW2TfzwcmvKQKq+5lRd7STdGTmu/n/nj7bP1N f1yRnLSZy+gjVqXLtHJaNNtYV+gED/aVhw+WJgno= Received: from smtp38.i.mail.ru (smtp38.i.mail.ru [95.163.41.79]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C43517511B6 for ; Tue, 9 Jan 2024 17:18:25 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C43517511B6 Received: by smtp38.i.mail.ru with esmtpa (envelope-from ) id 1rNCvw-00GQOL-2L; Tue, 09 Jan 2024 17:18:25 +0300 Date: Tue, 9 Jan 2024 17:18:24 +0300 To: Sergey Bronnikov Message-ID: References: <20231211112657.19060-1-max.kokryashkin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9F008C97756F746CA484E1B23D7B237301C4507AC9B9A7AAB182A05F53808504059D2A75AA867449171408E4429B862CA31877E40B856166E7C9C1C747143B184 X-C1DE0DAB: 0D63561A33F958A5B74B48C5228DA2C943530941550481C6BA6F1F98AB9CFFB8F87CCE6106E1FC07E67D4AC08A07B9B00A6B3CD6EB70C818BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742DC8270968E61249B1004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34411AA3F52B5778B6D18FC6D6CA4F1EA3710D95D069F3DCAFD9CA9210C167A1023B8B72D7BD9B43921D7E09C32AA3244CFF06025F156FBB3EE2D9FAA96F226F0624AF4FAF06DA24FDBAD658CF5C8AB4025DA084F8E80FEBD396F07DFE06A4A8314E894E437E78228B66933FA05BD8EF0CAD958392AE682691 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojou3Ii6fsdvUfp+C4BRVvqg== X-Mailru-Sender: 11C2EC085EDE56FA38FD4C59F7EFE40725F34C7FD986A180EFEF014A7F108F47D81B476BA9296889D51284F0FE6F529ABC7555A253F5B200DF104D74F62EE79D27EC13EC74F6107F4198E0F3ECE9B5443453F38A29522196 X-Mras: OK Subject: Re: [Tarantool-patches] [PATCH luajit] ARM64: Allow building with unwinding disabled. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Maxim Kokryashkin via Tarantool-patches Reply-To: Maxim Kokryashkin Cc: Maksim Kokryashkin , tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! On Fri, Dec 29, 2023 at 04:40:23PM +0300, Sergey Bronnikov wrote: > Hello, Max! > > thanks for the patch! LGTM with a minor comment > > On 12/11/23 14:26, Maksim Kokryashkin wrote: > > From: Mike Pall > > > > (cherry-picked from commit 5677985dc1f19cf0a67112f4365c7fb79237fa16) > > > > Prior to this patch, the LuaJIT build with the > > `-DLUAJIT_NO_UNWIND=1` option enabled failed on ARM64 because of > > linker relocation errors related to dwarf-specific code. This > > probably it is worth adding an error message produced by linker. > > Feel free to ignore. Added. Here is the new commit message: === ARM64: Allow building with unwinding disabled. (cherry-picked from commit 5677985dc1f19cf0a67112f4365c7fb79237fa16) Prior to this patch, the LuaJIT build with the `-DLUAJIT_NO_UNWIND=1` option enabled failed on ARM64 because of linker relocation error related to dwarf-specific code: | /usr/bin/ld: lj_vm_dyn.o: relocation R_AARCH64_PREL32 against | symbol `lj_err_unwind_dwarf' which may bind externally can not | be used when making a shared object; recompile with -fPIC | lj_vm_dyn.o:(.eh_frame+0x12): dangerous relocation: unsupported | relocation This patch disables emission of the `.eh_frame` section for builds without unwinding to solve the issue. The `LUAJIT_NO_UNWIND` build option is added to CMakeLists.txt. This patch adds this build flavor to our exotic builds workflow. Maxim Kokryashkin: * added the description for the problem Part of tarantool/tarantool#9145 === > > > >