From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 30142B021DA; Sun, 5 May 2024 15:39:17 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 30142B021DA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1714912757; bh=1IxiUjNpEq9+u81ZQ4kYM4K9s0s3OrbT4KjNLcf7Aik=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=zC15ix1drLggM55GhpmfBbQFfDvkjvlhMA0eoaykLb34Etakyg9Zjsm7KsjSM5N8/ G7YEh/koUuw3H15siru2/a09qV+MxmJ49vjm/3mlRkDD+Ilm1wkU8M2VjzxOghykya bP9hm2Dzp8Zbyid/m1bI3fO4agJi2Q2bajVplCuk= Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [95.163.41.99]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id ADCEBB021DA for ; Sun, 5 May 2024 15:39:15 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org ADCEBB021DA Received: by smtp61.i.mail.ru with esmtpa (envelope-from ) id 1s3b98-0000000CWBe-1nJY; Sun, 05 May 2024 15:39:15 +0300 Date: Sun, 5 May 2024 15:39:13 +0300 To: Sergey Kaplun Message-ID: References: <87a4c5c213df4e9f85eeb77d6cbb98dc2047c084.1713773432.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87a4c5c213df4e9f85eeb77d6cbb98dc2047c084.1713773432.git.skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9C1015E4FDF5377802B004185DE14697D9F6202D15800B4D2182A05F538085040F72D9BA142B5A1310578E6996F383413BCAE81402F66E066A5E5CAF7D1578E2397FFBCB1194FBF86 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7D6964C9E324ABA58EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006376DFCC587F0A0398D8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8DFEF0FA8E83FABA511F174CFCEF87692EC9686B7409CC6A4CC7F00164DA146DAFE8445B8C89999728AA50765F7900637DCE3DBD6F8E38AFD389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8B861051D4BA689FCF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C223C850C94764309302FCEF25BFAB3454AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C35E6A764B992000DCBA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF17B107DEF921CE791DD303D21008E298D5E8D9A59859A8B6D082881546D9349175ECD9A6C639B01B78DA827A17800CE7ED6B002596C5A4F0731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A57A689815A264B6C25002B1117B3ED696119500B2573B0D68CCE9A60C8CB01D7C823CB91A9FED034534781492E4B8EEAD9CFA8CFAC159CE19BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF6D226FDCAD5BC7EB8825F642184B9472C1DD313034F39021B0F127187D4CB08890F5B3B6BD0F620E643425263F8C9A4E7CC8AACBD04DBB6F66ADD2F9158FC961AB95CE53C0E89BBC5F4332CA8FE04980913E6812662D5F2A54F6898A6FDCBDC72A617DFBE5FEC2C6383653B6C8D9AE0FD16FCAA6493B703A X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj3Gch4W13RDHDvZXJcHj6BA== X-Mailru-Sender: 00097D31F91C944BAED0411CFB052B98A40CA1ED6C666C1DB951B70A5BD4BD8EF85A0E47D77DE422E28E2421BF3B429A04C9FB44FCBCE9EE92D99EB8CC7091A7ECEABDC5717908DEF544888E8238EB4872D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v1 1/5] build: introduce option LUAJIT_ENABLE_TABLE_BUMP X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Maxim Kokryashkin via Tarantool-patches Reply-To: Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the patch! LGTM, except for a few nits below. On Mon, Apr 22, 2024 at 11:49:54AM UTC, Sergey Kaplun wrote: > This option enables table bump optimization if sink optimization is > enabled. The table bump optimization patches the bytecodes with a table > allocation on the trace recording if the recorded trace exceeds the size > of the allocated table. This optimization still has some bugs, so it is > disabled by default. For more details, see the comment in > . > > Needed for tarantool/tarantool#9924 > --- > CMakeLists.txt | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/CMakeLists.txt b/CMakeLists.txt > index 2355ce17..52014296 100644 > --- a/CMakeLists.txt > +++ b/CMakeLists.txt > @@ -307,6 +307,23 @@ if(LUAJIT_ENABLE_COVERAGE) > include(CodeCoverage) > endif() > > +# Enable table bump optimization. This optimization patches the > +# bytecodes with a table allocation on the trace recording if the Typo: s/bytecodes/bytecode/ > +# recorded trace exceeds the size of the allocated table. > +# This optimization still has some bugs, so it is disabled by > +# default. See also: https://github.com/LuaJIT/LuaJIT/issues/606. > +option(LUAJIT_ENABLE_TABLE_BUMP "Enable table bump optimization" OFF) > +if(LUAJIT_ENABLE_TABLE_BUMP) > + # Within table bump optimization enabled (and due to our Typo: s/Within/With/ > + # modification related to metrics), some offsets in `GG_State` > + # stop fit in 12bit immediate. Hence, the build failed due to > + # the DASM error (DASM_S_RANGE_I). > + if(CMAKE_SYSTEM_PROCESSOR STREQUAL "aarch64") > + message(FATAL_ERROR "Table Bump optimization is unsupported for aarch64") Typo: s/Bump/bump/ > + endif() > + AppendFlags(TARGET_C_FLAGS -DLUAJIT_ENABLE_TABLE_BUMP) > +endif() > + > # --- Main source tree --------------------------------------------------------- > > add_subdirectory(src) > -- > 2.44.0 >