From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 043F09E7969; Thu, 21 Mar 2024 13:13:17 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 043F09E7969 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1711015997; bh=w7PvUwgppRllixjWmb0n6RM33J3XoafLYYk6YgomfWw=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Fy3AdF2c6Sdo882Pec3VZuaqiZTNnONsKcB4UUFwN0LpU8zTKhAxF0RN+BQDj4cQu IgdI/MxblGZIFw3C9IorOvvjvCUzghrg17UbnUMbP3LY3TXQFRGjj+oLa7OKqfxydB /7HOrKEpY+xygNUJfcaBjxXxNWDbYEVY+j/ZuV+g= Received: from smtp35.i.mail.ru (smtp35.i.mail.ru [95.163.41.76]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id BC4989E7940 for ; Thu, 21 Mar 2024 13:13:15 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BC4989E7940 Received: by smtp35.i.mail.ru with esmtpa (envelope-from ) id 1rnFQA-0000000DIOL-0rQ8; Thu, 21 Mar 2024 13:13:14 +0300 Date: Thu, 21 Mar 2024 13:13:13 +0300 To: Sergey Bronnikov Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD94D5EF110843E6A673F0195B5121F8A534CFD228B4CE77F1D182A05F5380850404C228DA9ACA6FE272D21480625BC5E12AC8EDD30083ED68EAF1447E7DC5EB494C3BC3EA3FE9A8BB0B64211BEE0CFEDE2 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F544D30F1A6FA191EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063725D748B084CAA27D8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8B12E6A3C3D9B4FC5AF234633B46EE3D8F7D77242BB2C0D08CC7F00164DA146DAFE8445B8C89999728AA50765F7900637DCE3DBD6F8E38AFD389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8A9FF340AA05FB58CF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C7812A6222701F2156E0066C2D8992A164AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C3A73855355308332DBA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF27ED053E960B195E1DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C332C16DEEF884694935872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5972FD8549C5498ED5002B1117B3ED696D06540620E9DA744957033528158102E823CB91A9FED034534781492E4B8EEADA3FB0D9844EF8EC5BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFBB2D6ED96698B77B7FE46AEB1E0BA6679147EAA620068DB3DA849D66FA81BE24744A43F78FC6FA90A5E652D4FCD6795A9F2707FA856A90EDD23EBFF696ADB6330F6D91EF352D8CA7C226CC413062362A913E6812662D5F2A54F6898A6FDCBDC72A617DFBE5FEC2C6383653B6C8D9AE0FD16FCAA6493B703A X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojt33F1wIes245v/zMq+NweQ== X-Mailru-Sender: 7940E2A4EB16C9976F80DCDCD59EC227176E8045CF6149ABAC8EDD30083ED68EAF1447E7DC5EB494E2527C969975515CFF9FCECFB8D89CB6C77752E0C033A69E235A20A81F3B0E39AB3C5F247CB2F7F93A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] cmake: fix warnings about minimum required version X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Maxim Kokryashkin via Tarantool-patches Reply-To: Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the patch! Please consider my comments below. On Thu, Mar 21, 2024 at 11:33:29AM +0300, Sergey Bronnikov wrote: > From: Sergey Bronnikov > > CMake produces annoying warnings: > > CMake Deprecation Warning at src/CMakeLists.txt:7 (cmake_minimum_required): > Compatibility with CMake < 3.5 will be removed from a future version of > CMake. > > We cannot bump a minimum required CMake version without > bumping it in a Tarantool build system. However, we can set Typo: s/in a/in the/ > a max supported CMake version and suppress a warning. Please specify in the commit message and in comments in cmake files that maximum supported version means "maximum version this CMake file is known to work properly" and will not result in any build errors rightaway for higher versions. > CMake 3.27.7 is a version used by me for a long time for > building LuaJIT. This version is tested and seen no policy warnings Typo: s/is tested/has been tested/ Typo: s/there have been/ > with a that version. Typo: s/a that/that/ > --- > Branch: https://github.com/tarantool/luajit/tree/ligurio/fix-cmake-warnings > Doc: https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html > > NOTE: another solution is using CMAKE_WARN_DEPRECATED, > but I don't like it. Let's discuss. > > 1. https://cmake.org/cmake/help/latest/variable/CMAKE_WARN_DEPRECATED.html > > CMakeLists.txt | 2 +- > etc/CMakeLists.txt | 2 +- > src/CMakeLists.txt | 2 +- > src/host/CMakeLists.txt | 2 +- > test/CMakeLists.txt | 2 +- > test/LuaJIT-tests/CMakeLists.txt | 2 +- > test/LuaJIT-tests/src/CMakeLists.txt | 2 +- > test/PUC-Rio-Lua-5.1-tests/CMakeLists.txt | 2 +- > test/PUC-Rio-Lua-5.1-tests/libs/CMakeLists.txt | 2 +- > test/lua-Harness-tests/CMakeLists.txt | 2 +- > test/tarantool-tests/CMakeLists.txt | 2 +- > tools/CMakeLists.txt | 2 +- > 12 files changed, 12 insertions(+), 12 deletions(-) > > diff --git a/CMakeLists.txt b/CMakeLists.txt > index 7f5e2afb..9edff6f3 100644 > --- a/CMakeLists.txt > +++ b/CMakeLists.txt > @@ -8,7 +8,7 @@ >