From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 5CFA1559629; Wed, 2 Aug 2023 11:33:00 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5CFA1559629 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1690965180; bh=+dRqvkReCSzgnW7/h9N6601f2D/RNAIU2E56NTt3x58=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=DfKg83jTrmgi+NW6xw704otdry/Y/ZDNOlZNX0bKj2LyBPcIyCSAZKL5aAYF0O1mJ xlZlDho8fVLiwC8e0LwzjUpQPuxFyA8Mk7Kq5eCiRl1ieaKHfIsEFMhA/hM3OWPdUD xZMqg223PNtpU9Eg5tCqFeB30kKRbJv216YSmfb0= Received: from smtp54.i.mail.ru (smtp54.i.mail.ru [95.163.41.89]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 38C2955961F for ; Wed, 2 Aug 2023 11:32:59 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 38C2955961F Received: by smtp54.i.mail.ru with esmtpa (envelope-from ) id 1qR7Ht-008Eak-1q; Wed, 02 Aug 2023 11:32:58 +0300 Date: Wed, 2 Aug 2023 11:32:57 +0300 To: Igor Munkin Message-ID: References: <20230710112400.1802-1-max.kokryashkin@gmail.com> <2e5eayfduee7hlxwdd2fthtgg4aibmohyc5ti7hcskpzswkv5y@t5eoedfsqx2n> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD93761F2630DFFAF41A06C3F00224CE1B2857C7744A811472E182A05F5380850406B48629321011D2B4270B8631A18494F7FD8BA8FE298F9253ABD81AD66D10B9F X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE788A2BECDB72C1542EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637C1CDCB5E4A85220F8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D843245B7ECD2B6DD05D96731725D884A5117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC3A703B70628EAD7BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735209647ADFADE5905B1E5D25F19253116ADD2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE0AC5B80A05675ACD4D0DA9BD313A0613D8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE3F8BD4E506CFA3D882D242C3BD2E3F4C6C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947C0839144E5BB460BA2E808ACE2090B5E1725E5C173C3A84C390BCC82C2C62A6D1089D37D7C0E48F6C8AA50765F7900637BC468E7E89D8C5D6EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A55E198B65A38A28224A4F6F43E9CC3AC3FCBBFCA02305D5F3F87CCE6106E1FC07E67D4AC08A07B9B05E59ED9F89912417BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF5C74C050D7D2370AE795BE36FF745495282328CE87344ADB13F5A3C52A0A991AE125D5F9813FCCC58553022043D0BC9A2D58F44FABF331C4B450C49BA24F40A6461A413F07889F2102C26D483E81D6BE64ACE4A408B72B61B0CA6F94E606A667A52EF62A646584F811BD90D3D42C882D43082AE146A756F3 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojV0vAgLNnFuc8s6AedcsSqQ== X-Mailru-Sender: 7940E2A4EB16C9974CFF14AB62FAC150410A80C127A38E4E66080CFEF598DE7AE2527C969975515CFF9FCECFB8D89CB6C77752E0C033A69E235A20A81F3B0E39AB3C5F247CB2F7F93A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v7] memprof: introduce cli flag to run dump parser X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Maxim Kokryashkin via Tarantool-patches Reply-To: Maxim Kokryashkin Cc: Maksim Kokryashkin , tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Igor, On Wed, Aug 02, 2023 at 08:12:50AM +0000, Igor Munkin wrote: > Max, > > On 02.08.23, Maxim Kokryashkin wrote: > > Hi, Igor! > > > > Well, I see no obstacles with flag handling in Tarantool. > > For instance, the -j flag proxy can do exactly what you want. > > > > | review/tarantool/build fckxorg/gh-5688-cli-for-memprof-parse ✔ 239d16h > > | ▶ ./src/tarantool -j on -e 'print(jit.status())' > > | true fold cse dce fwd dse narrow loop abc sink fuse > > | > > | review/tarantool/build fckxorg/gh-5688-cli-for-memprof-parse ✔ 239d16h > > | ▶ ./src/tarantool -j off -e 'print(jit.status())' > > | false fold cse dce fwd dse narrow loop abc sink fuse > > > > My bad, I'm concerted rather about this difference and its effect in > Tarantool flags processing: > | $ ./luajit -bl -e 'print("qq")' > | -- BYTECODE -- "print("qq")":0-1 > | 0001 GGET 0 0 ; "print" > | 0002 KSTR 1 1 ; "qq" > | 0003 CALL 0 1 2 > | 0004 RET0 0 1 > | > | $ cd ../src/tools > | $ ../src/luajit -tm -e 'print("qq")' > | luajit-parse-memprof.lua: ERROR: unrecognized option `-e'. Try `--help'. > | > > In other words, I wonder > * whether flags in Tarantool are position independent (i.e. the result > of -j + -e combination equals to -e + -j); | review/tarantool/build fckxorg/gh-5688-cli-for-memprof-parse ✔ 239d17h | ▶ ./src/tarantool -e 'print(jit.status())' -jon | false fold cse dce fwd dse narrow loop abc sink fuse | | review/tarantool/build fckxorg/gh-5688-cli-for-memprof-parse ✔ 239d17h | ▶ ./src/tarantool -jon -e 'print(jit.status())' | true fold cse dce fwd dse narrow loop abc sink fuse So no, they are not position-independent. > * how --leak-only will be handled in this case. I can just pass further args after the -tm right to the memprof parser module then. > > BTW, I have a thought regarding introducing kinda "mode" for memprof, so > we can use it like -tm=leak-only (as an alternative to the original > proposal in the first message). > > Besides, I see no tests for --leak-only (have no idea, why everyone > missed this on review). Could you add them? Yep, sure. > > > Tarantool's flag handling is not pleasant to say the least, > > but we should try to do the same as with -j. > > > > Best regards, > > Maxim Kokryashkin > > > > > > On Wed, Aug 02, 2023 at 07:23:03AM +0000, Igor Munkin wrote: > > > Max, > > > > > > We've discussed with Sergey K. how to run -tm with --leak-only today. > > > Fortunately, it works fine in LuaJIT, however, I'm afraid such flag > > > handling in incompatible in Tarantool. Hence, I suggest to glue this > > > flag with comma to -tm, like jdump does[1]. Thoughts? > > > > > > [1]: https://github.com/tarantool/luajit/blob/tarantool/master/src/jit/dump.lua#L18 > > > > > > -- > > > Best regards, > > > IM > > -- > Best regards, > IM