From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 2EBFB650353; Fri, 8 Sep 2023 14:04:24 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2EBFB650353 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1694171064; bh=c4Z3+reGdgm8ihK2sJ8bslhTDj1sSNMeGUuNKlNI2Gg=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=WIJ3VMzEVFkUmyNLx3j0lCBR3Fgh6BQvncD+T3rWyL0ytTRVQp8BFz1wpHG3a3fha a9lPfpP3vBM+hg/brrUM4ENNvaQc7WJMkllS8gGqmz+I1W39S4+5FHQotJ6EyFYjhG JI/6pSklAmLHoHPZxXe7dj+GjlyyD7V1HrcoBeDA= Received: from smtp50.i.mail.ru (smtp50.i.mail.ru [95.163.41.92]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7640E559A02 for ; Fri, 8 Sep 2023 14:04:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7640E559A02 Received: by smtp50.i.mail.ru with esmtpa (envelope-from ) id 1qeZHX-005Zsb-2w; Fri, 08 Sep 2023 14:04:13 +0300 Date: Fri, 8 Sep 2023 14:04:11 +0300 To: Sergey Bronnikov Message-ID: References: <17d72b1b-0ac1-0f72-c72e-ff0f1f2d69f6@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <17d72b1b-0ac1-0f72-c72e-ff0f1f2d69f6@tarantool.org> X-Mailru-Src: smtp X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD96E142CFC92DB15CD1C47060D0B6C1F571E4C5B5C7DEF200F182A05F538085040A0855880C77E7EF33A06B79EF78D9376C277F3DA4FA5D5771ACF7766C6CC52C4 X-C1DE0DAB: 0D63561A33F958A52375AC42E0DDFD0B97A46FF7A41BA8ACCF6947CC3F2F0D3BF87CCE6106E1FC07E67D4AC08A07B9B013BDA61BF53F5E1DCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF77DD89D51EBB7742DC8270968E61249B1004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D3494FB0335DF05DC3A6B3BA685487E8A3C28B16072300E6E8495B2556584DC786DDCF6B7208753219F1D7E09C32AA3244C29234EC46076DACFFD9B3072F1AF0696E8FBBEFAE1C4874CBAD658CF5C8AB4025DA084F8E80FEBD396F07DFE06A4A8314E894E437E78228B66933FA05BD8EF0CAD958392AE682691 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojHV97et/Y5fztGApiO7sOYw== X-Mailru-Sender: 11C2EC085EDE56FA38FD4C59F7EFE4076034D394DFDCA4DC4EFA036793FD07AE8735D1064880384AD51284F0FE6F529ABC7555A253F5B200DF104D74F62EE79D27EC13EC74F6107F4198E0F3ECE9B5443453F38A29522196 X-Mras: OK Subject: Re: [Tarantool-patches] [PATCH luajit 1/2] memprof: refactor symbol resolution X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Maxim Kokryashkin via Tarantool-patches Reply-To: Maxim Kokryashkin Cc: Maxim Kokryashkin , tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! On Tue, Sep 05, 2023 at 02:47:15PM +0300, Sergey Bronnikov wrote: > Hi, Max > > > thanks for the patch! LGTM with a two minor comments. > > > It is not related to submitted patches, but anyway - there is a typo: > > --- a/test/tarantool-tests/misclib-memprof-lapi.test.lua > +++ b/test/tarantool-tests/misclib-memprof-lapi.test.lua > @@ -36,7 +36,7 @@ local function default_payload() >    -- Preallocate table to avoid table array part reallocations. >    local _ = table_new(20, 0) > > -  -- Want too see 20 objects here. > +  -- Want to see 20 objects here. >    for i = 1, 20 do >      -- Try to avoid crossing with "test" module objects. >      _[i] = "memprof-str-"..i I don't really want to change it in scope of this patch set, so ignoring. > Nit: this change is not relevant. In the branch hunk is different: > > @@ -86,44 +86,17 @@ local function form_source_line(line, source) >  end > >  local function form_trace_line(traceno, line, source) > -  return ("TRACE [%d] %s:%d"):format(traceno, source or SRC_PATH, line) > +  return ("TRACE [%d] started at %s:%d"):format( > +    traceno, > +    source or SRC_PATH, > +    line > +  ) >  end It is not irrelevant. This patchset required tests to be rewritten, which resulted in addition of `started at` to this format string and it went over the 80-character limit. > >