From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id C31106A8C65; Tue, 24 Oct 2023 17:49:58 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C31106A8C65 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1698158998; bh=xnOG4ChQfx0Cw4WGv+fs4/oUr3jkNBBgX4PxkMWaANM=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=bNwFBF2zQu2+JOK+OknRPmbmfJc1J4S8onxA8FVHTLS9Br77HXNOEYNgmCxqIg3ld SNzhimBYYqaZ2HzH88p3T66zWwOkGm+hHeIyGNTqJqTCBSEYdq49vLCxkB6XoSOIHp XwtqowyktgjsuzH7gA0ymshM6piJ9hAxCuIHi4cU= Received: from smtp54.i.mail.ru (smtp54.i.mail.ru [95.163.41.89]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 703486A8C65 for ; Tue, 24 Oct 2023 17:49:57 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 703486A8C65 Received: by smtp54.i.mail.ru with esmtpa (envelope-from ) id 1qvIjD-009FED-2q; Tue, 24 Oct 2023 17:49:56 +0300 Date: Tue, 24 Oct 2023 17:49:55 +0300 To: Sergey Kaplun Message-ID: References: <30f685beb2bf4ce39dd82ede7b10c821af5c6f0d.1698049570.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <30f685beb2bf4ce39dd82ede7b10c821af5c6f0d.1698049570.git.skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD96DD1678B4DC47D344C796B53B5200C120A455E3A932C0172182A05F5380850404C228DA9ACA6FE272903D2DFBE91E0B2992F275EDCFA5D196853AF21085AFB73BAB6833395D7563F X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7548C33FFD72831AFEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063781E06E36B00F36668638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D862F141D5A34310B4670F015B2C16CC63117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC3A703B70628EAD7BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD1828451B159A507268D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE0AC5B80A05675ACD9935A1E27F592749D8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE3F8BD4E506CFA3D88C0837EA9F3D19764C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CD2DCF9CF1F528DBC2E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89FB26E97DCB74E625235872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A52B172DDCE8DA9FB0266C7E8F191CF9CB36B452A93AEDFACFF87CCE6106E1FC07E67D4AC08A07B9B02A336C6518635091CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34FA5A4D623E7343BB4D71C4EDE31C1BD44A8A50D9260B76D41914BFAF079C9BACC7750BA742D407801D7E09C32AA3244C86F897FEB30FF60920ACDD60AFE41FA3435BF7150578642F85A42E4C463514DC5DA084F8E80FEBD396F07DFE06A4A8314E894E437E78228B66933FA05BD8EF0CAD958392AE682691 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojHVN7eoC00vkJqUu+O4kKmg== X-Mailru-Sender: 7940E2A4EB16C997FE3FA4BCD65AE2C99359647A4004C501A1B59FFF83953260E2527C969975515CFF9FCECFB8D89CB6C77752E0C033A69E235A20A81F3B0E39AB3C5F247CB2F7F93A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/6] FFI: Fix missing cts->L initialization in argv2ctype(). X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Maxim Kokryashkin via Tarantool-patches Reply-To: Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the patch! LGTM, except for a few nits regarding the commit message. On Mon, Oct 23, 2023 at 12:22:02PM +0300, Sergey Kaplun wrote: > From: Mike Pall > > (cherry-picked from commit 50d6883e6027c4c2f9a5e495fee6b7fff1bd73c9) Incorrect hash, should be: a622e2eb559c823d90c7af85935ca63706e4593d > > When start trace recording without an initialized `L` in CType State > (possible if the recording is started before any `ffi` library usage), > the corresponding assertion fails in the `lj_ctype_intern()`. This patch > adds missing initialization during recording. Please explicitly mention that the test case fails only when the LuaJIT is built with -DLUA_USE_ASSERT=ON. > > Sergey Kaplun: > * added the description and the test for the problem > > Part of tarantool/tarantool#9145 > --- Best regards, Maxim Kokryashkin