From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 2F177704267; Fri, 17 Nov 2023 13:51:12 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2F177704267 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1700218272; bh=JEQLw/6EIwfEtuGpHXNds3kuR0Kj9KHmztcU95YFu2I=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=k7v5L/48WJcn48ayYTaZtsY2MoPGyfSeyl6Q5Z23xHIpaIi05+xrOfuhO962ityu0 iJT8x0c9J67fiWWBvrQkbKrFs6vE09mVCwj6EEjpmRm/P9BmMdBNnlUktplt+iq3yT peXW7lPkaI0cclZX+n89myBNfE8KQN1zvxE/q8RI= Received: from smtp37.i.mail.ru (smtp37.i.mail.ru [95.163.41.78]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D1964704267 for ; Fri, 17 Nov 2023 13:51:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D1964704267 Received: by smtp37.i.mail.ru with esmtpa (envelope-from ) id 1r3wRJ-000XBG-1V; Fri, 17 Nov 2023 13:51:09 +0300 Date: Fri, 17 Nov 2023 13:51:09 +0300 To: Sergey Kaplun Message-ID: References: <20231116134456.5898-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231116134456.5898-1-skaplun@tarantool.org> X-Mailru-Src: smtp X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9BE2AA157F04678487A33E32BE3FBF935015569BDBD2A1B54182A05F5380850404C228DA9ACA6FE27E05920DF28823F7D4BE11D5C80E8B149D8CF9D99FADC3E31824711C945BE8A1B X-C1DE0DAB: 0D63561A33F958A5857523887356983DF9D8AA7CB1F07098298C00A86472F1B0F87CCE6106E1FC07E67D4AC08A07B9B01E44367C8E80A7B4CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0AD5177F0B940C8B66ECE892A7B2722663E91682638B966EB3F662256BEEFA9527F88D0BBAFBCA9AE3DDEF410C48CD344023527853AD5CF72E0C62589E17D4A323853630F0D66B5CDF037FD76D11AF80A0DF2F250452D325997E946080A9E49556DEA455F16B58544A2557BDE0DD54B3590965026E5D17F6739C77C69D99B9914278E50E1F0597A6FD5CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojWWC/ZYCun+WbP+7kKRbkYg== X-Mailru-Sender: 11C2EC085EDE56FA38FD4C59F7EFE407B4E7DA34DEB575BC4DE7C240C96FDC4623261FF1C387AD76D51284F0FE6F529ABC7555A253F5B200DF104D74F62EE79D27EC13EC74F6107F4198E0F3ECE9B5443453F38A29522196 X-Mras: OK Subject: Re: [Tarantool-patches] [PATCH luajit] test: add test for conversions folding X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Maxim Kokryashkin via Tarantool-patches Reply-To: Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the patch! LGTM, except for the single nit regarding the commit message. On Thu, Nov 16, 2023 at 04:44:56PM +0300, Sergey Kaplun wrote: > This patch adds the test for commit > 1a401622fe83ae695226c94df3416e312315d659 ("Fix assertions."). This patch > removes incorrect assertions in the fold optimizations for conversions > from numbers to different integer types. Although the issue affects only Typo: s/Although/Since/ > branch 2.0, there is no need to fix it. Nevertheless, the test is > required to avoid regressions in the future. > > Part of tarantool/tarantool#9145 > --- > > Branch: https://github.com/tarantool/luajit/tree/skaplun/lj-833-fold-conv-from-num > Tarantool PR: https://github.com/tarantool/tarantool/pull/9375 > Related issues: > * https://github.com/LuaJIT/LuaJIT/issues/833 > * https://github.com/tarantool/tarantool/issues/9145 > > .../lj-833-fold-conv-from-num.test.lua | 33 +++++++++++++++++++ > 1 file changed, 33 insertions(+) > create mode 100644 test/tarantool-tests/lj-833-fold-conv-from-num.test.lua