From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 9AAF39BCFDC; Wed, 31 Jan 2024 15:26:09 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9AAF39BCFDC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1706703969; bh=E4T8fvdAGIcB6zPg7qLR6VvOxR+Aj4D9VTh4/A3pCgU=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=iUT6Dsp4o75ff43S3TT5CINUlw+jq3zWSIT0LJ3aTdv4UIX/kIC7lbnnEVMtNy8gb aouB+q5mrMKnBdNpFq+MPPmsLhayyzKMtWrMnwCk/K9HVwf+gQZuXtQJbdAeo44AUr j7B/VPVRgROeZRWb1D2Y3mqam9opiSFQGYLz5SDU= Received: from smtp32.i.mail.ru (smtp32.i.mail.ru [95.163.41.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 821819BCFD9 for ; Wed, 31 Jan 2024 15:26:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 821819BCFD9 Received: by smtp32.i.mail.ru with esmtpa (envelope-from ) id 1rV9fL-00000008hD8-0Dxj; Wed, 31 Jan 2024 15:26:08 +0300 Date: Wed, 31 Jan 2024 15:26:06 +0300 To: Sergey Kaplun Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9DF1FFD52FB7F4A950B941F2BA89398A05886C6D8E2B7214600894C459B0CD1B9FF70B2A244CFD74CF8DDC052C0A89C6FBD0A1460F0A808253815EF3C1FD4079265B98BC17AE4ABE7 X-C1DE0DAB: 0D63561A33F958A5279F8379BAD73D795002B1117B3ED6961FD70349413C4306108A05421C070DB8823CB91A9FED034534781492E4B8EEAD1247ADC107F68C7B X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF77DD89D51EBB7742D3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF07D9D4E2AADCD7B174CB47B4E1207FE419BD459E59D01C6079ADA4C5728DB7399B17B6A7F8D99C9BBAF4CF3B87E910B1B8B4D3BFCD3D20D770A66F56BC38FFDFCE7116F40FE8944A5F4332CA8FE04980913E6812662D5F2A54F6898A6FDCBDC72A617DFBE5FEC2C6383653B6C8D9AE0FD16FCAA6493B703A X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojqJaWtPsRtymBoO7H9d0lxQ== X-Mailru-Sender: 11C2EC085EDE56FA38FD4C59F7EFE407DD09D6C078C1AFBDB951B70A5BD4BD8E32493F644B99B95C7AD558DE3329E34404C9FB44FCBCE9EE92D99EB8CC7091A7ECEABDC5717908DEF544888E8238EB4872D6B4FCE48DF648AE208404248635DF X-Mras: OK Subject: Re: [Tarantool-patches] [PATCH v2 luajit 05/26] test: enable in LuaJIT-tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Maxim Kokryashkin via Tarantool-patches Reply-To: Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the patch! LGTM, except for the single nit below. On Mon, Jan 29, 2024 at 01:45:05PM +0300, Sergey Kaplun wrote: > This patch removes unused `dofile()`. Also, it names the only one test > as "misc" and includes the test in . > > Part of tarantool/tarantool#9398 > --- > test/LuaJIT-tests/lib/ffi/ffi_bitfield.lua | 4 +--- > test/LuaJIT-tests/lib/ffi/index | 1 + > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/test/LuaJIT-tests/lib/ffi/ffi_bitfield.lua b/test/LuaJIT-tests/lib/ffi/ffi_bitfield.lua > index cd0b1815..fa74e45d 100644 > --- a/test/LuaJIT-tests/lib/ffi/ffi_bitfield.lua > +++ b/test/LuaJIT-tests/lib/ffi/ffi_bitfield.lua > @@ -1,8 +1,6 @@ > local ffi = require("ffi") > > -dofile("../common/ffi_util.inc") > - > -do > +do --- misc Nit: Maybe `misc bitfield tests` then for it to be more elaborate? Or maybe it should be spplitted according to the sections inside the test. > local x = ffi.new([[ > union { > uint32_t u; > diff --git a/test/LuaJIT-tests/lib/ffi/index b/test/LuaJIT-tests/lib/ffi/index > index 7e046908..8d833107 100644 > --- a/test/LuaJIT-tests/lib/ffi/index > +++ b/test/LuaJIT-tests/lib/ffi/index > @@ -3,6 +3,7 @@ cdata_var.lua > copy_fill.lua > err.lua > ffi_arith_ptr.lua > +ffi_bitfield.lua > istype.lua > jit_array.lua > jit_complex.lua > -- > 2.43.0 >