From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 13784A0292C; Wed, 31 Jan 2024 17:32:24 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 13784A0292C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1706711544; bh=hJABf6WXYyKyd895hgJ+mR/mrS3tFGMYbQp8/Gi9hl4=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=HhdVYxDVVfcAKOWyBeH3JOWQH5Y6kV3udrQ1ihqV+iJd6qvndAc/3tEfXaBN42/g6 xGxQ8Kdpr2UILwhJBGQrvuB8z+2MkaR2gw5P5tjr2zuMaw3sbsrGe/QdNqXN3nxFqb 1hhpVnFh6oR57Gh/4rqno70MquoiLli4C/eoRao0= Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [95.163.41.90]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E7F92A02900 for ; Wed, 31 Jan 2024 17:32:21 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E7F92A02900 Received: by smtp53.i.mail.ru with esmtpa (envelope-from ) id 1rVBdU-00000008qbb-1wwU; Wed, 31 Jan 2024 17:32:21 +0300 Date: Wed, 31 Jan 2024 17:32:20 +0300 To: Sergey Kaplun Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD93C58C36AA2E99649913F598E3EEE18285DA7E33959698359182A05F5380850404C228DA9ACA6FE271113E87F1E8CCE48C7A4B249DE6549FD5AA5F0ACED8AC164903BC3FD69C482F07B32B127E1E343F9 X-C1DE0DAB: 0D63561A33F958A5377A65C404375D225002B1117B3ED69602C3C917BA66578E92212597CCBD6D77823CB91A9FED034534781492E4B8EEAD1247ADC107F68C7B X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF77DD89D51EBB7742D3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF1C60D0E0B97A136E1BC9750058804EFEAC96BBDDEF10D353BB85149D49E36C9266401EE05C14F77DBAF4CF3B87E910B197107192B4B1E1FBFE6DB6E9E9471209D9060D2571BFC0435F4332CA8FE04980913E6812662D5F2A54F6898A6FDCBDC72A617DFBE5FEC2C6383653B6C8D9AE0FD16FCAA6493B703A X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojqJaWtPsRtymG30KfFInY4Q== X-Mailru-Sender: 11C2EC085EDE56FA38FD4C59F7EFE4073864895D72AE538FB951B70A5BD4BD8EA35F42C01CB73370B67A942A63B4089A04C9FB44FCBCE9EE92D99EB8CC7091A7ECEABDC5717908DEF544888E8238EB4872D6B4FCE48DF648AE208404248635DF X-Mras: OK Subject: Re: [Tarantool-patches] [PATCH v2 luajit 08/26] test: enable in LuaJIT-tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Maxim Kokryashkin via Tarantool-patches Reply-To: Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the patch! LGTM, except for the question below. On Mon, Jan 29, 2024 at 01:45:08PM +0300, Sergey Kaplun wrote: > This patch changes the `dofile()` (which uses an unreliable relative > file path and mutates `_G` with global functions to be defined) to the > corresponding `require()`. Also, it names the only one test as "misc" > and includes the test in . > > Part of tarantool/tarantool#9398 > --- > test/LuaJIT-tests/lib/ffi/ffi_const.lua | 4 ++-- > test/LuaJIT-tests/lib/ffi/index | 1 + > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/test/LuaJIT-tests/lib/ffi/ffi_const.lua b/test/LuaJIT-tests/lib/ffi/ffi_const.lua > index d42133ad..3213156d 100644 > --- a/test/LuaJIT-tests/lib/ffi/ffi_const.lua > +++ b/test/LuaJIT-tests/lib/ffi/ffi_const.lua > @@ -1,6 +1,6 @@ > local ffi = require("ffi") > > -dofile("../common/ffi_util.inc") > +local fails = require("common.fails") > > ffi.cdef[[ > typedef struct s_t { > @@ -41,7 +41,7 @@ typedef struct foo_t { > } foo_t; > ]] > > -do > +do --- misc Again, maybe it is worth splitting into the subcategories that are mentioned below. > local foo_t = ffi.typeof("foo_t") > local x = foo_t() > > diff --git a/test/LuaJIT-tests/lib/ffi/index b/test/LuaJIT-tests/lib/ffi/index > index 9a22104a..0a72daed 100644 > --- a/test/LuaJIT-tests/lib/ffi/index > +++ b/test/LuaJIT-tests/lib/ffi/index > @@ -6,6 +6,7 @@ ffi_arith_ptr.lua > ffi_bitfield.lua > ffi_call.lua > ffi_callback.lua > +ffi_const.lua > istype.lua > jit_array.lua > jit_complex.lua > -- > 2.43.0 >