From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id DBAB2A04CD2; Wed, 31 Jan 2024 18:07:14 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DBAB2A04CD2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1706713635; bh=MPeqWNHgE0BFdfaUozkYSBNLHQZnFMXFMxVTYuR1UKg=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=bYhfZA2PclJS8enmmukbA3lALZ0Do/uW461uZigFgW/PX4H4lGNKi1UN9hhm57LMj irY/bj/7SqIXxKbHbkSVV0f52IT96cPYxS+Nj6NFaZZ9EVq1aaQSo7H6R/IeU6j5Cx uXPv7uZP/gwjTpNtXS9Fl0aIEGfSGuXdPISavF98= Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [95.163.41.99]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 35198A04CD5 for ; Wed, 31 Jan 2024 18:07:14 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 35198A04CD5 Received: by smtp61.i.mail.ru with esmtpa (envelope-from ) id 1rVCBE-00000005IWD-3UUP; Wed, 31 Jan 2024 18:07:13 +0300 Date: Wed, 31 Jan 2024 18:07:12 +0300 To: Sergey Kaplun Message-ID: References: <6279ec45b1a87b07f14827da242e82aed866e250.1706520765.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6279ec45b1a87b07f14827da242e82aed866e250.1706520765.git.skaplun@tarantool.org> X-Mailru-Src: smtp X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD9A3FCF9DB4FFE09557E0DAFAE04B70BC6803E2FF36D1D1772182A05F5380850405D6A72286BE7D99ED27678DDAA8063145EC03169C1BE6B09F4AF36F856BF577373C1DF025D8865E1 X-C1DE0DAB: 0D63561A33F958A59FAD326512BE5FBB5002B1117B3ED696B48A4DE9178EEABF22DFD5397F446790823CB91A9FED034534781492E4B8EEAD01200A96CB7104FFBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF77DD89D51EBB7742D3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF17F350D3AD1A5CA83D5A6AE8006ADA8911FB6A53F3349B6E2604C7BAA9D639C9065B4C0772F80DDCBAF4CF3B87E910B183FAAE846A1F2264F3132357EF13543FD1AE33E88E3300E35F4332CA8FE04980913E6812662D5F2A54F6898A6FDCBDC72A617DFBE5FEC2C6383653B6C8D9AE0FD16FCAA6493B703A X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojqJaWtPsRtykqWkkZOvxkLw== X-Mailru-Sender: 11C2EC085EDE56FA38FD4C59F7EFE407980F64B7C7359049B951B70A5BD4BD8E1A6D1330106630CBBE4EBEF89FC7D6FA04C9FB44FCBCE9EE92D99EB8CC7091A7ECEABDC5717908DEF544888E8238EB4872D6B4FCE48DF648AE208404248635DF X-Mras: OK Subject: Re: [Tarantool-patches] [PATCH v2 luajit 11/26] test: enable X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Maxim Kokryashkin via Tarantool-patches Reply-To: Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the patch! LGTM, except for the single nit below. On Mon, Jan 29, 2024 at 01:45:11PM +0300, Sergey Kaplun wrote: > This patch declares functions as local to avoid pollution of the global > environment. It separates the body of the test in the `do` `while` block > and includes the test in . > > Part of tarantool/tarantool#9398 > --- > .../lib/ffi/ffi_gcstep_recursive.lua | 27 ++++++++++--------- > test/LuaJIT-tests/lib/ffi/index | 1 + > 2 files changed, 15 insertions(+), 13 deletions(-) > > diff --git a/test/LuaJIT-tests/lib/ffi/ffi_gcstep_recursive.lua b/test/LuaJIT-tests/lib/ffi/ffi_gcstep_recursive.lua > index cb19df11..f6e0b009 100644 > --- a/test/LuaJIT-tests/lib/ffi/ffi_gcstep_recursive.lua > +++ b/test/LuaJIT-tests/lib/ffi/ffi_gcstep_recursive.lua > @@ -1,6 +1,6 @@ > -- From Robert G. Jakabosky, 2012-03-20 > > -local N=tonumber(arg[1] or 10000) > +local N= 10000 Something wrong with formatting here.