From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 49A7D9FF425; Thu, 1 Feb 2024 11:38:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 49A7D9FF425 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1706776710; bh=4ReADu+jIJxUDodaALM6ASoJjWimR+6wjpb4+Wza9Kc=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=dcE99g3Owj7KMfbLTiD5lEpClZixnqOWq7hBuFGO2AW3mAdTLgwaUOywEjfFpmj4o T04FoFdHzAwI5h/7PmEMLxKjxFLmx4HEMDffQxvdg9jPehOJ00AtMkg/nbA9rtvGcX YT0t+vuDiKrmDjT128JhxZ5hMKCHLvxYkW07MnOs= Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [95.163.41.88]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7A62D9FF40F for ; Thu, 1 Feb 2024 11:38:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7A62D9FF40F Received: by smtp52.i.mail.ru with esmtpa (envelope-from ) id 1rVSaa-000000079Ck-1zk5; Thu, 01 Feb 2024 11:38:28 +0300 Date: Thu, 1 Feb 2024 11:38:28 +0300 To: Sergey Kaplun Message-ID: References: <762aa9e5928117192f7fc9f1c5df0f6d5f478fbe.1706520765.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <762aa9e5928117192f7fc9f1c5df0f6d5f478fbe.1706520765.git.skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9A3FCF9DB4FFE095545EA9E4C205CC53F92B022658B46D736182A05F53808504003AC0FAE37DA0D1C91417EB218679B820980390881D618488CACC14F0751AF36CAD80AB92358092F X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7B865BA2AB0AE8E25EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637103BD9D8542B9C568638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8B984E58F8EEB6A88EE0167ABE1BF6374E48956D3588AD800CC7F00164DA146DAFE8445B8C89999728AA50765F7900637F924B32C592EA89F389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC82FFDA4F57982C5F4F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947CAD74539164518AE5BA3038C0950A5D36C8A9BA7A39EFB766D91E3A1F190DE8FDBA3038C0950A5D36D5E8D9A59859A8B6389ED70FDB73D44F3AA81AA40904B5D99C9F4D5AE37F343AD1F44FA8B9022EA23BBE47FD9DD3FB595F5C1EE8F4F765FC8C7ADC89C2F0B2A5E2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8BDC0F6C5B2EEF3D0C75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A534A3E49DE495E2515002B1117B3ED696CC2FA2BEBD749B71FB820E9FE7BD014C823CB91A9FED034534781492E4B8EEAD01200A96CB7104FFBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF5D9F7E8C7452C7A8CB9B62C5663844195BF38ECEC34B94DAFF7D48AAD2AE7939760962882471415BBAF4CF3B87E910B1F02A9368D35C644A8F99CC9C8FA4D32F1BE4C930945BE8CD5F4332CA8FE04980913E6812662D5F2A54F6898A6FDCBDC72A617DFBE5FEC2C6383653B6C8D9AE0FD16FCAA6493B703A X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojqJaWtPsRtyk3l7isMqvYaA== X-Mailru-Sender: 7940E2A4EB16C9970E7603824FE97C2005B06E9A4B1D736BDD65A51EF95C307C6F3331269E9AD96AB6F7D78CE1F58EAD61AD1BC23DFB21333DDE9B364B0DF289BB83A8C3DAEBA78A61AAEF30F77CACB9EAB4BC95F72C04283CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 15/26] test: enable in LuaJIT-tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Maxim Kokryashkin via Tarantool-patches Reply-To: Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the patch! Please consider two comments below. On Mon, Jan 29, 2024 at 01:45:15PM +0300, Sergey Kaplun wrote: > This patch changes the `dofile()` (which uses an unreliable relative > file path and mutates `_G` with global functions to be defined) to the > corresponding `require()`. Also, it adds groups with the names of > subtests and enables the test in . > > Part of tarantool/tarantool#9398 > --- > test/LuaJIT-tests/lib/ffi/ffi_lex_number.lua | 72 +++++++++++--------- > test/LuaJIT-tests/lib/ffi/index | 1 + > 2 files changed, 39 insertions(+), 34 deletions(-) > > diff --git a/test/LuaJIT-tests/lib/ffi/ffi_lex_number.lua b/test/LuaJIT-tests/lib/ffi/ffi_lex_number.lua > index e26650ef..ca6c65c5 100644 > --- a/test/LuaJIT-tests/lib/ffi/ffi_lex_number.lua > +++ b/test/LuaJIT-tests/lib/ffi/ffi_lex_number.lua > @@ -1,6 +1,6 @@ > local ffi = require("ffi") > > -dofile("../common/ffi_util.inc") > +local checkfail = require("common.ffi.checkfail") > > local function checklex(t) > for i=1,1e9,2 do > @@ -14,38 +14,42 @@ local function checklex(t) > end > end > > -checklex{ > - "0LL", "0ll", > - "0LL", "0LL", > - "0ULL", "0ull", > - "0ULL", "0ULl", > - "18446744073709551615ULL", "18446744073709551615llu", > - "9223372036854775807LL", "0x7fffffffffffffffll", > - "9223372036854775808ULL", "0x8000000000000000ull", > - "1311768467463790320LL", "0x123456789abcdef0ll", > - "-1LL", "-1ll", > - "18446744073709551615ULL", "-1ull", > - "-9223372036854775807LL", "-0x7fffffffffffffffll", > - "9223372036854775808ULL", "-0x8000000000000000ull", > - "0+0i", "0i", > - "0+0i", "0I", > - "0+12.5i", "12.5i", > - "0+4660i", "0x1234i", > - "0+infI", "1e400i", > - "0-infI", "-1e400i", > - "0-12.5i", "-12.5i", > - "0-0i", "-0i", > -} > +do --- checklex Maybe we can come up with a more elaborate name? > + checklex{ > + "0LL", "0ll", > + "0LL", "0LL", > + "0ULL", "0ull", > + "0ULL", "0ULl", > + "18446744073709551615ULL", "18446744073709551615llu", > + "9223372036854775807LL", "0x7fffffffffffffffll", > + "9223372036854775808ULL", "0x8000000000000000ull", > + "1311768467463790320LL", "0x123456789abcdef0ll", > + "-1LL", "-1ll", > + "18446744073709551615ULL", "-1ull", > + "-9223372036854775807LL", "-0x7fffffffffffffffll", > + "9223372036854775808ULL", "-0x8000000000000000ull", > + "0+0i", "0i", > + "0+0i", "0I", > + "0+12.5i", "12.5i", > + "0+4660i", "0x1234i", > + "0+infI", "1e400i", > + "0-infI", "-1e400i", > + "0-12.5i", "-12.5i", > + "0-0i", "-0i", > + } > +end > > -checkfail({ > - "0l", > - "0lll", > - "0u", > - "0ul", > - "0ulll", > - "0wll", > - "0xll", > - ".0ll", > - "0ii", > -}, function(s) assert(loadstring("return "..s)) end) > +do --- checkfail Same here. > + checkfail({ > + "0l", > + "0lll", > + "0u", > + "0ul", > + "0ulll", > + "0wll", > + "0xll", > + ".0ll", > + "0ii", > + }, function(s) assert(loadstring("return "..s)) end) > +end > > diff --git a/test/LuaJIT-tests/lib/ffi/index b/test/LuaJIT-tests/lib/ffi/index > index 71def57b..833c31e3 100644 > --- a/test/LuaJIT-tests/lib/ffi/index > +++ b/test/LuaJIT-tests/lib/ffi/index > @@ -13,6 +13,7 @@ ffi_gcstep_recursive.lua > ffi_jit_arith.lua > ffi_jit_call.lua > ffi_jit_conv.lua > +ffi_lex_number.lua > istype.lua > jit_array.lua > jit_complex.lua > -- > 2.43.0 >