From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 497665DC634; Tue, 5 Sep 2023 11:56:11 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 497665DC634 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1693904171; bh=PHzU0O8m5SkR3aDKNwAZAsa9sTgSSrPdSapnnC3wE6w=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=MnxNbtx45PQdWFxoTd9gaeJDK6cYunTBuXWp2GdbZnISox3Gb0+UbMPLSg92G03kP jMDHJWc99bWI546muIj+5s6i81hnR2WP1+gPIwVA8cwB5TScK6PLdoq3taCzUgdfAF tGCSRNUdgQW6lpPFUuCLngJFVjYhkQUZ/RYOjOvo= Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [95.163.41.99]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E944656C761 for ; Tue, 5 Sep 2023 11:56:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E944656C761 Received: by smtp61.i.mail.ru with esmtpa (envelope-from ) id 1qdRqw-00CWeP-1c; Tue, 05 Sep 2023 11:56:06 +0300 Date: Tue, 5 Sep 2023 11:56:06 +0300 To: Sergey Kaplun Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD96201AD55A1C8F7DB4B94316895B7D143959E6F65F85AE25C182A05F5380850404C228DA9ACA6FE27BA599F1412896FC784342D3F1F282101B98EA3CF811D4D4822BCA9F13A422CD5 X-C1DE0DAB: 0D63561A33F958A5D95CE78ADF620B52B7E529579318E8D86EF70D9CB5795A30F87CCE6106E1FC07E67D4AC08A07B9B0DB8A315C1FF4794DBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF77DD89D51EBB7742DC8270968E61249B1004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D348F9E8EBB462314877905094F7D6FA1B49852F3980A4C0FC2542CE9F25CF4E43F0930235C4A15B3491D7E09C32AA3244C86E7C2FA5DA21546EA5EA3B96E6CF4C9A8CE788DE683120585A42E4C463514DC5DA084F8E80FEBD396F07DFE06A4A8314E894E437E78228B66933FA05BD8EF0CAD958392AE682691 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj3VBHtC3oXrMSTj6WSXACGg== X-Mailru-Sender: 11C2EC085EDE56FA38FD4C59F7EFE4075FF4EEE6C8DD775C5FE94FCDAAE8C58ACB83A82A306BA1DAD51284F0FE6F529ABC7555A253F5B200DF104D74F62EE79D27EC13EC74F6107F4198E0F3ECE9B5443453F38A29522196 X-Mras: OK Subject: Re: [Tarantool-patches] [PATCH luajit 3/3] test: fix fix-mips64-spare-side-exit-patching X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Maxim Kokryashkin via Tarantool-patches Reply-To: Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! LGTM, except for the single nit regarding the commit message below. On Mon, Sep 04, 2023 at 06:50:26PM +0300, Sergey Kaplun wrote: > This test may be flaky due to a non-monotonic filling of the vector with I believe, that 'sparse' is a better fit here then 'non-monotonic'. It is just a widely adopted term for vectors like this. > traces. Hence, `misc.getmetrics().jit_trace_num` (which is the total > number of traces) is not the last trace number, so there is no mcode for > it. > > This patch fixes flakyness from two sides: > * The `fillmcode()` function now starts a search from the given trace > itself, so there is no possible inconsistency with the growing vector. > * The finding of the last trace number in the aforementioned test is now > more bulletproof: we scan all numbers from the metrics value to the > maxtrace value. The last number with an existing mcode is chosen as > the resulting last trace number. > --- > ...x-mips64-spare-side-exit-patching.test.lua | 22 ++++++++++++++++--- > test/tarantool-tests/utils/jit/generators.lua | 5 ++--- > 2 files changed, 21 insertions(+), 6 deletions(-)