Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Maxim Kokryashkin <max.kokryashkin@gmail.com>,
	tarantool-patches@dev.tarantool.org, skaplun@tarantool.org,
	imun@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit v5 1/2] debug: generalized extension
Date: Tue, 19 Dec 2023 11:01:39 +0300	[thread overview]
Message-ID: <ffc9053a-23df-4251-89a0-317b6e7ddbaa@tarantool.org> (raw)
In-Reply-To: <ad503780c89db82bad7cdf96876ef97b5050f3fb.1701872037.git.m.kokryashkin@tarantool.org>

Hi, Max


thanks for the patch! LGTM

I appreciate your efforts in deduplication code,

I believe it will reduce maintenance cost for these extensions.


On 12/6/23 17:14, Maxim Kokryashkin wrote:
> This patch joins the LLDB and GDB LuaJIT debugging extensions
> into one, so now the extension logic can be debugger-agnostic.
> To do that, an adapter class is introduced, and all of the
> debugger-specific behavior is encapsulated there. The extension
> auto-detects the debugger it was loaded into and selects the
> correct low-level logic implementation.
> ---
<snipped>

  reply	other threads:[~2023-12-19  8:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-06 14:14 [Tarantool-patches] [PATCH luajit v5 0/2] " Maxim Kokryashkin via Tarantool-patches
2023-12-06 14:14 ` [Tarantool-patches] [PATCH luajit v5 1/2] " Maxim Kokryashkin via Tarantool-patches
2023-12-19  8:01   ` Sergey Bronnikov via Tarantool-patches [this message]
2023-12-06 14:14 ` [Tarantool-patches] [PATCH luajit v5 2/2] test: add tests for debugging extensions Maxim Kokryashkin via Tarantool-patches
2023-12-19  8:16   ` Sergey Bronnikov via Tarantool-patches
2023-12-19 14:34     ` Maxim Kokryashkin via Tarantool-patches
2023-12-20 12:23       ` Sergey Bronnikov via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ffc9053a-23df-4251-89a0-317b6e7ddbaa@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=max.kokryashkin@gmail.com \
    --cc=sergeyb@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit v5 1/2] debug: generalized extension' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox