From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 60BCD6EC56; Fri, 19 Mar 2021 02:04:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 60BCD6EC56 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616108648; bh=i+evHsjzgYgUTv7Ik7441Uv4Z6Z1QtuH13PQgb6VcSQ=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=kCQJF8yrsNY3q6gbyat9DZ/MM/hCD4Y6lnydoLX3+XTv4Z/0sZbX/oelu5nM718bT 6A+BnHGpoKLYS+pUbjKvhkxp22jbKd67UMGkr99z72s6YCiDI8yHKVl5Op3YRV3mhH TflSeBpv+bFKaQBLhtJJ+NVCXS/avkyhu3S/OSVk= Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3E6DD6EC56 for ; Fri, 19 Mar 2021 02:04:07 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3E6DD6EC56 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1lN1gU-00079B-1Q; Fri, 19 Mar 2021 02:04:06 +0300 To: Cyrill Gorcunov References: <20210317185743.964278-1-gorcunov@gmail.com> <20210317212350.GA224985@starling> <20210318051812.GB224985@starling> <20210318075127.GA4019@starling> <2cab3281-33f8-7a59-384b-41364501e57d@tarantool.org> <34718073-d3ec-87fb-3d75-302acca3484f@tarantool.org> Message-ID: Date: Fri, 19 Mar 2021 00:04:04 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD96485A7A9FC13189348F8A4374722721B2CC8EA71D516B2F1182A05F538085040F9CACF8756AD1EBD3BE86232396061A1E3D5217C87E051E79C4545342FE43D09 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE705C173BDDADFC82AEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375D54B99ECAFA2F678638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C81A23F326053F827CB77AC9F0B6FA927B4DBEACDE4F8E240A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE74601F13E4625331C9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3643C8550F8485502117882F4460429728AD0CFFFB425014E868A13BD56FB6657A7F4EDE966BC389F9E8FC8737B5C22499DC5D3EDC80DC730089D37D7C0E48F6CCF19DD082D7633A0E7DDDDC251EA7DABAAAE862A0553A39223F8577A6DFFEA7C6492012CB0DFA22D43847C11F186F3C5E7DDDDC251EA7DABCC89B49CDF41148F6B16E133A9586FB82623479134186CDE6BA297DBC24807EABDAD6C7F3747799A X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2BBE337FB72E923155C0AF1600DCBC20BD52826C51A2876ABB3843C03DDF9E111 X-C1DE0DAB: 0D63561A33F958A5C51C3FC80B1787807EB8891BCA3A6779DC40D425F27C4E36D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34DA1FE609583D493C9C24F0B01A18F33E57B0605A160D96C632AD8171B41DC4FD91A285932B98BAF01D7E09C32AA3244CA4BCEE6707FB4EFB48094425779E4C973FD9C8CA1B0515E08D5DD81C2BAB7D1D X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojyKyJYJ15DtKxnDeZLnICJw== X-Mailru-Sender: 689FA8AB762F73936BC43F508A0638223CC27BB7108A624DA3B3D010C5C8FC233841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [RFC] gc/xlog: delay xlog cleanup until relays are subscribed X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Cc: Mons Anderson , tml Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On 18.03.2021 22:31, Cyrill Gorcunov wrote: > On Thu, Mar 18, 2021 at 09:54:12PM +0100, Vladislav Shpilevoy wrote: >>>> >>>> Then it should have 'replication_' prefix, not 'wal_'. Because >>>> it is ignored if replicas connect before the timeout expires. >>> >>> Replication is one of the reason while main gamer is "wal" >>> here. In the series I sent recently I named it "wal_cleanup_delay". >>> In future we might introduce some topology detector as you've >>> been suggesting and better to not stick to "replication" >>> prefix I think. >> >> The thing you said is just another argument for it having 'replication' >> prefix. Because topology also is not about WAL. > > Topology is anoter _reason_ to defer wal cleanup, and there might > be other reasons unrelated to replications at all. Topology is a part of replication. It **is** replication. If there would be other reasons, your option won't work, because replication simply drops it when all nodes are connected. > On the other > hands I see what you mean and won't insist. Should I name it > replication_cleanup_delay then? I don't know yet. I would call it replication_max_gc_delay probably. But you need to ask Mons for a final decision. Perhaps he will insist on wal_cleanup_delay. See my other points in the v2 thread.