From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 82A7642EF5C
 for <tarantool-patches@dev.tarantool.org>;
 Sun, 21 Jun 2020 19:24:37 +0300 (MSK)
References: <cover.1591701695.git.sergepetrenko@tarantool.org>
 <3992b9bc805ebc1d83ff59d5c1050b89a6a66344.1591701695.git.sergepetrenko@tarantool.org>
 <02a64ca9-70c3-2dc9-7105-d30e5af211e4@tarantool.org>
 <58d703db-2bca-87cd-ba55-0ff3a23c6d5b@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <ff6efb88-a73f-bb3c-20fe-e8c0395b95b1@tarantool.org>
Date: Sun, 21 Jun 2020 18:24:35 +0200
MIME-Version: 1.0
In-Reply-To: <58d703db-2bca-87cd-ba55-0ff3a23c6d5b@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 1/8] replication: introduce
 space.is_sync option
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Leonid Vasiliev <lvasiliev@tarantool.org>, Serge Petrenko <sergepetrenko@tarantool.org>, sergos@tarantool.org, gorcunov@gmail.com
Cc: tarantool-patches@dev.tarantool.org

Hi! Thanks for the review!

> Maybe, it is needed to add is_sync to the box_space_mt() function in
> schema.lua
> LGTM.

Added in a separate commit:

====================
commit 8ea5476e1c34a7592567644b9d58af838e97317c
Author: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Date:   Sun Jun 21 18:07:40 2020 +0200

    replication: add is_sync to space serialization
    
    [TO BE SQUASHED INTO THE PREVIOUS COMMIT]

diff --git a/src/box/lua/schema.lua b/src/box/lua/schema.lua
index a91b4fbad..2edf25fae 100644
--- a/src/box/lua/schema.lua
+++ b/src/box/lua/schema.lua
@@ -2706,6 +2706,7 @@ local function box_space_mt(tab)
                 engine = v.engine,
                 is_local = v.is_local,
                 temporary = v.temporary,
+                is_sync = v.is_sync,
             }
         end
     end