From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 7D5BB12E2519; Thu, 20 Mar 2025 15:53:26 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7D5BB12E2519 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1742475206; bh=aW7AQowzQMiwYCmw2xBDQv4s8IqudbD/7u/KyNquWQ0=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=aDXKtSnK2IEc0vZ524TqHr++Tb7sd5UmsTl+aNB1LGpBjgoVNYalqvVX2apcsDAmG 6cY6fH27Xa3sPimgMxAh4begxu4vGkWT5ZqogiwHCquXQ4g5/La7OU3alRB90GpyO1 3DXG/RvGECAfF90AQwwFzewnSQ+XikTfwOkGiKSA= Received: from send126.i.mail.ru (send126.i.mail.ru [89.221.237.221]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 41F6212E2520 for ; Thu, 20 Mar 2025 15:53:25 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 41F6212E2520 Received: by exim-smtp-75f69ddc6c-jd98j with esmtpa (envelope-from ) id 1tvFOm-00000000GhX-0e48; Thu, 20 Mar 2025 15:53:24 +0300 Content-Type: multipart/alternative; boundary="------------6O51b2ojMd6lkkc2mRf0rrnK" Message-ID: Date: Thu, 20 Mar 2025 15:53:23 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: <20250227160013.2040-1-skaplun@tarantool.org> Content-Language: en-US In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9B515C74AF55DBE73D54FC2D27906162B933F0840095E2EF0182A05F5380850404C228DA9ACA6FE270101FE5C29C9051D3DE06ABAFEAF6705BFAF43F3AC38C016CB478398FDC3786C7454BA882483358B X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE792C68BF9CD4C0E9EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637FE9EFE935CD7C6AE8638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B24AFFB9F294D07F332E070BE324C7D3C46A8C32A0865253DFF6B57BC7E64490618DEB871D839B73339E8FC8737B5C2249957A4DEDD2346B42CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C078FCF50C7EAF9C588941B15DA834481F9449624AB7ADAF37BA3038C0950A5D3613377AFFFEAFD269176DF2183F8FC7C0CAB4775CB929E3BB7B076A6E789B0E97A8DF7F3B2552694AD5FFEEA1DED7F25D49FD398EE364050F9647ADFADE5905B1F41620B44FB51B7DB3661434B16C20ACC84D3B47A649675FE827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F7900637B8FA30D9455089A722CA9DD8327EE4930A3850AC1BE2E735B17145F0B7815491C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5177F1E43A9A3783B5002B1117B3ED69697FCB83C8F2A6621957033528158102E823CB91A9FED034534781492E4B8EEAD3CCD70CEBBF18A22BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34EC58E35A639A2471B882DFC17E0EDA5A01294B0B10A0ABCCFB5FABC77C252635CB91D5FA746B0F751D7E09C32AA3244CECE6B3141202E8BC77DD89D51EBB774247BE87EE471BDA71EA455F16B58544A2E30DDF7C44BCB90DA5AE236DF995FB59978A700BF655EAEEED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVRxnlmV4XzQlaK993jlKjEc= X-Mailru-Sender: 520A125C2F17F0B1E52FEF5D219D6140D21A358135BEFFB9479CDAE959BF642464D55F11C80E26D90152A3D17938EB451EB5A0BCEC6A560B3DDE9B364B0DF289BE2DA36745F2EEB5CEBA01FB949A1F1EEAB4BC95F72C04283CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Fix IR_ABC hoisting. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------6O51b2ojMd6lkkc2mRf0rrnK Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Thanks! LGTM On 20.03.2025 15:38, Sergey Kaplun wrote: > Hi, Sergey! > Thanks for the review! > Fixed your comments, rebased the branch on the tarantool/master > and force-pushed it. > > On 20.03.25, Sergey Bronnikov wrote: >> Hi, Sergey! >> >> thanks for the patch! LGTM with minor comments that can be ignored. >> >> Sergey >> >> On 27.02.2025 19:00, Sergey Kaplun wrote: >>> From: Mike Pall > > >>> +local function test_func() >>> + -- 1 iteration for hotcount warm-up. 2 and 3 to record invariant >> As usually we care about readers, I propose to make text more >> human-firendly: >> >> s/1/The first/ >> >> s/2 and 3/second and third/ >> > Fixed, see the iterative patch below. > =================================================================== > diff --git a/test/tarantool-tests/lj-1194-abc-hoisting.test.lua b/test/tarantool-tests/lj-1194-abc-hoisting.test.lua > index 3a78c34e..57fbc584 100644 > --- a/test/tarantool-tests/lj-1194-abc-hoisting.test.lua > +++ b/test/tarantool-tests/lj-1194-abc-hoisting.test.lua > @@ -39,9 +39,10 @@ local table_new = require('table.new') > jit.opt.start('hotloop=1', '-fuse') > > local function test_func() > - -- 1 iteration for hotcount warm-up. 2 and 3 to record invariant > - -- and variant parts of the loop. The trace is run via an > - -- additional call to this function. > + -- The first iteration for hotcount warm-up. The second and > + -- third are needed to record invariant and variant parts of the > + -- loop. The trace is run via an additional call to this > + -- function. > local limit = 3 > -- Create a table with a fixed array size (`limit` + 1), so all > -- access to it fits into the array part. > =================================================================== > >>> + -- and variant parts of the loop. The trace is run via an > > --------------6O51b2ojMd6lkkc2mRf0rrnK Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Thanks! LGTM

On 20.03.2025 15:38, Sergey Kaplun wrote:
Hi, Sergey!
Thanks for the review!
Fixed your comments, rebased the branch on the tarantool/master
and force-pushed it.

On 20.03.25, Sergey Bronnikov wrote:

Hi, Sergey!

thanks for the patch! LGTM with minor comments that can be ignored.

Sergey

On 27.02.2025 19:00, Sergey Kaplun wrote:

From: Mike Pall <mike>

<snipped>


+local function test_func()
+  -- 1 iteration for hotcount warm-up. 2 and 3 to record invariant

As usually we care about readers, I propose to make text more 
human-firendly:

s/1/The first/

s/2 and 3/second and third/


Fixed, see the iterative patch below.
===================================================================
diff --git a/test/tarantool-tests/lj-1194-abc-hoisting.test.lua b/test/tarantool-tests/lj-1194-abc-hoisting.test.lua
index 3a78c34e..57fbc584 100644
--- a/test/tarantool-tests/lj-1194-abc-hoisting.test.lua
+++ b/test/tarantool-tests/lj-1194-abc-hoisting.test.lua
@@ -39,9 +39,10 @@ local table_new = require('table.new')
 jit.opt.start('hotloop=1', '-fuse')
 
 local function test_func()
-  -- 1 iteration for hotcount warm-up. 2 and 3 to record invariant
-  -- and variant parts of the loop. The trace is run via an
-  -- additional call to this function.
+  -- The first iteration for hotcount warm-up. The second and
+  -- third are needed to record invariant and variant parts of the
+  -- loop. The trace is run via an additional call to this
+  -- function.
   local limit = 3
   -- Create a table with a fixed array size (`limit` + 1), so all
   -- access to it fits into the array part.
===================================================================


+  -- and variant parts of the loop. The trace is run via an

<snipped>
--------------6O51b2ojMd6lkkc2mRf0rrnK--