From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 42C6021083 for ; Wed, 27 Jun 2018 09:11:05 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OLDOgGNINIL8 for ; Wed, 27 Jun 2018 09:11:05 -0400 (EDT) Received: from smtp57.i.mail.ru (smtp57.i.mail.ru [217.69.128.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 00D9B20C45 for ; Wed, 27 Jun 2018 09:11:04 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH][vshard] Reload reloadable fiber From: Vladislav Shpilevoy References: <20180614114202.2634-1-avkhatskevich@tarantool.org> <45c2c224-6bfa-c54d-7654-36961a9d1c66@tarantool.org> <0c6f7167-d61d-010e-9ba5-5c08244a5bb9@tarantool.org> <527ad322-e091-dcf6-ad74-5de5a4fcc6ac@tarantool.org> <51114d53-806d-5c65-3424-7a965a434a98@tarantool.org> <43e5ead7-f6fd-6eda-dfc5-3a9bee2eab0a@tarantool.org> <5536a4f7-f598-a7d4-0b92-a3483a7a339b@tarantool.org> <4dc68f8e-ad09-d818-3ea2-2eb6cb890d37@tarantool.org> Message-ID: Date: Wed, 27 Jun 2018 16:11:02 +0300 MIME-Version: 1.0 In-Reply-To: <4dc68f8e-ad09-d818-3ea2-2eb6cb890d37@tarantool.org> Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Alex Khatskevich , tarantool-patches@freelists.org Thanks for the fixes! The patch is pushed. On 27/06/2018 14:53, Vladislav Shpilevoy wrote: > > > On 27/06/2018 14:45, Alex Khatskevich wrote: >> I have rebased and pushed, but... >> >> Non of the tests fails. >> >> As far as I know, there is a couple of blinking tests in vshard. > > VShard now has no unstable tests. I got error on your new test, and > even with no rebase it appears sometimes: > > >     ====================================================================================== >     WORKR TEST                                            PARAMS          RESULT >     --------------------------------------------------------------------------------- >     [001] unit/util.test.lua                                              [ fail ] >     [001] >     [001] Test failed! Result content mismatch: >     [001] --- unit/util.result    Wed Jun 27 14:46:34 2018 >     [001] +++ unit/util.reject    Wed Jun 27 14:52:17 2018 >     [001] @@ -39,11 +39,11 @@ >     [001]  ... >     [001]  test_run:grep_log('default', 'Worker_name: reloadable function reloadable_function has been changed') >     [001]  --- >     [001] -- 'Worker_name: reloadable function reloadable_function has been changed' >     [001] +- null >     [001]  ... >     [001]  test_run:grep_log('default', 'Worker_name is reloaded, restarting') >     [001]  --- >     [001] -- Worker_name is reloaded, restarting >     [001] +- null >     [001]  ... >     [001]  test_run:grep_log('default', 'Worker_name has been started') >     [001]  --- >     [001] > > I think it is because you cancel fiber too early in the test. Please, repair. > >> >> >> On 27.06.2018 14:34, Vladislav Shpilevoy wrote: >>> Please, rebase on the latest master branch. When I do, >>> the tests fail. >