From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id F083B5F7ED6; Fri, 15 Sep 2023 10:28:07 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org F083B5F7ED6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1694762888; bh=L5nczXbb5FX2tLM/HSMYOjFFh4AYTpWFX0KEdnYDlFA=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=CtYPrAotF8spVC2LpG+bNABoikg0Oal5dTxHoqkvBwa1vCSQYuSUqQ3bIJlhuTAZ+ nfjx7j+7OIXeVM2GclpxkZtqvc23fgUyLnRMPALCi055DNN3ZA5b1oeCDaoHu7kvW2 dzHI2Z5zBIsqFZHXzH0Xy9XW3i0mi92qlBRjWnA0= Received: from smtp37.i.mail.ru (smtp37.i.mail.ru [95.163.41.78]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id EC46856C777 for ; Fri, 15 Sep 2023 10:28:06 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org EC46856C777 Received: by smtp37.i.mail.ru with esmtpa (envelope-from ) id 1qh3FF-000gPJ-1j; Fri, 15 Sep 2023 10:28:06 +0300 Message-ID: Date: Fri, 15 Sep 2023 10:28:05 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Content-Language: en-US To: Sergey Kaplun , Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org References: <20230829095440.30540-1-skaplun@tarantool.org> In-Reply-To: <20230829095440.30540-1-skaplun@tarantool.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD927CFE6CA1630A10C17FD82B4F6BE161DBE2DAF84B2ECACBA00894C459B0CD1B99ED03A728F4D6F51A5A2A4C1705F0F70D705F4CEEC79F5D450B51C660DE91301 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7B264C8851FD8E810EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006378D7045943A292EC88638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D88010D4FF1D6FB6E82F65156B3A2ECDFF117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC974A882099E279BDA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18F04B652EEC242312D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE9647ADFADE5905B1CEDA8D6C8C3B0531D8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE3F254576263B31EA96E0066C2D8992A16C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637BC13DA0749B57ECEEFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5E8DBEC36E2DEC19E081FF09A9E51F0C1E009ED81786A57A7F87CCE6106E1FC07E67D4AC08A07B9B08ED1AC82D843A2BBCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D341B5517184E88C1BD44F69AE91F124BA36CD53F6CF9FA2495E64B70CEAE382C2FADE18DBD97EBC9151D7E09C32AA3244C3049185AD9963BD7C07AA73C91A5FBC11E098CBE561D634385A42E4C463514DC5DA084F8E80FEBD3FFA33E6B6B2F82C47A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojYiMmPA/XhkXyaQiRJ+G4fw== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A769071FA4E6CA4BCC69B4D6A5519030C8257AD558DE3329E344EBA65886582A37BD66FEC6BF5C9C28D98A98C1125256619760D574B6FC815AB872D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Fix handling of instable types in TNEW/TDUP load forwarding. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey thanks for the patch! LGTM And see my minor comments below. On 8/29/23 12:54, Sergey Kaplun wrote: > -- TDUP. > ---[[ > --- FIXME: Disable test case for now. Enable, with another > --- backported commit with a fix for the aforementioned issue > --- (and after patch "Improve assertions."). > --- Test taken trace exits too. > for _ = 1, 5 do > local t = slot > -- Now use constant key slot to get necessary branch. > @@ -48,6 +43,5 @@ for _ = 1, 5 do Nit: assert is triggered with 3 iterations too > slot = _ % 2 ~= 0 and stored_tab or {true} Nit: I would left a comment with explanation why exactly this value is assigned to slot. > end > test:is(result, true, 'TDUP load forwarding was successful') > -]] > > test:done(true)