Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v21 6/6] test: add box.lib test
Date: Tue, 13 Apr 2021 00:08:56 +0200	[thread overview]
Message-ID: <fd095b1e-35f6-22a5-9cb1-2a17cba2ff9f@tarantool.org> (raw)
In-Reply-To: <YHN6AbWsDLApYqdm@grain>

Thanks for the fixes!

Please, apply this diff:

====================
diff --git a/test/box/cfunc4.c b/test/box/cfunc4.c
index a03a23026..0cf6fd8fa 100644
--- a/test/box/cfunc4.c
+++ b/test/box/cfunc4.c
@@ -1,4 +1,4 @@
-#include <msgpuck.h>
+#include "msgpuck.h"
 #include "module.h"
 
 /*
diff --git a/test/box/lib.result b/test/box/lib.result
index 5067e9b36..2a89e78d1 100644
--- a/test/box/lib.result
+++ b/test/box/lib.result
@@ -348,9 +348,6 @@ fio.symlink(cfunc3_path, cfunc_path)
 box.schema.func.create('cfunc.cfunc_add', {language = "C"})
  | ---
  | ...
-box.schema.user.grant('guest', 'execute', 'function', 'cfunc.cfunc_add')
- | ---
- | ...
 box.func['cfunc.cfunc_add']:call({1, 2})
  | ---
  | - 3
diff --git a/test/box/lib.test.lua b/test/box/lib.test.lua
index 93cea90b6..076a43389 100644
--- a/test/box/lib.test.lua
+++ b/test/box/lib.test.lua
@@ -136,7 +136,6 @@ _ = pcall(fio.unlink(cfunc_path))
 -- appear in box.lib hash.
 fio.symlink(cfunc3_path, cfunc_path)
 box.schema.func.create('cfunc.cfunc_add', {language = "C"})
-box.schema.user.grant('guest', 'execute', 'function', 'cfunc.cfunc_add')
 box.func['cfunc.cfunc_add']:call({1, 2})
 
 -- Now we have 2 refs for low level module (when function

  reply	other threads:[~2021-04-12 22:09 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-08 16:41 [Tarantool-patches] [PATCH v21 0/6] box: implement box.lib Lua module Cyrill Gorcunov via Tarantool-patches
2021-04-08 16:41 ` [Tarantool-patches] [PATCH v21 1/6] box/func: fix modules functions restore Cyrill Gorcunov via Tarantool-patches
2021-04-09 23:31   ` Vladislav Shpilevoy via Tarantool-patches
2021-04-10 15:02     ` Cyrill Gorcunov via Tarantool-patches
2021-04-08 16:41 ` [Tarantool-patches] [PATCH v21 2/6] box/func: module_reload -- drop redundant argument Cyrill Gorcunov via Tarantool-patches
2021-04-08 16:41 ` [Tarantool-patches] [PATCH v21 3/6] box/module_cache: introduce modules subsystem Cyrill Gorcunov via Tarantool-patches
2021-04-09 23:54   ` Vladislav Shpilevoy via Tarantool-patches
2021-04-10 14:59     ` Cyrill Gorcunov via Tarantool-patches
2021-04-08 16:41 ` [Tarantool-patches] [PATCH v21 4/6] box/schema.func: switch to new module api Cyrill Gorcunov via Tarantool-patches
2021-04-09 23:55   ` Vladislav Shpilevoy via Tarantool-patches
2021-04-10 15:00     ` Cyrill Gorcunov via Tarantool-patches
2021-04-08 16:41 ` [Tarantool-patches] [PATCH v21 5/6] box: implement box.lib module Cyrill Gorcunov via Tarantool-patches
2021-04-11 15:38   ` Vladislav Shpilevoy via Tarantool-patches
2021-04-11 22:38     ` Cyrill Gorcunov via Tarantool-patches
2021-04-12 22:08       ` Vladislav Shpilevoy via Tarantool-patches
2021-04-12 22:34         ` Cyrill Gorcunov via Tarantool-patches
2021-04-08 16:41 ` [Tarantool-patches] [PATCH v21 6/6] test: add box.lib test Cyrill Gorcunov via Tarantool-patches
2021-04-08 18:53   ` Cyrill Gorcunov via Tarantool-patches
2021-04-11 15:43     ` Vladislav Shpilevoy via Tarantool-patches
2021-04-11 21:56       ` Cyrill Gorcunov via Tarantool-patches
2021-04-11 22:36       ` Cyrill Gorcunov via Tarantool-patches
2021-04-12 22:08         ` Vladislav Shpilevoy via Tarantool-patches [this message]
2021-04-13  7:10           ` Cyrill Gorcunov via Tarantool-patches
2021-04-13 21:53 ` [Tarantool-patches] [PATCH v21 0/6] box: implement box.lib Lua module Vladislav Shpilevoy via Tarantool-patches
2021-04-14  8:07 ` Kirill Yukhin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fd095b1e-35f6-22a5-9cb1-2a17cba2ff9f@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=gorcunov@gmail.com \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v21 6/6] test: add box.lib test' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox