Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>,
	Maxim Kokryashkin <m.kokryashkin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] test: fix typo in the link to the issue
Date: Tue, 26 Mar 2024 17:12:01 +0300	[thread overview]
Message-ID: <fce4c390-634d-467b-849c-46c46060b10f@tarantool.org> (raw)
In-Reply-To: <20240320071920.30953-1-skaplun@tarantool.org>

LGTM

On 3/20/24 10:19, Sergey Kaplun wrote:
> This patch is a follow-up to the
> 8ec08fc9ed5a6d2b2ee115572e0434a9f5dec99c ("Respect jit.off() on pending
> trace exit."). It fixes the typo 'issue'->'issues' to correct the link.
>
> Follows up tarantool/tarantool#9595
> ---
>
> Since this is just a typo fix, I disabled integration testing (linters
> will be disabled too for the "-notest" prefix, so it isn't omitted).
>
> Branch: https://github.com/tarantool/luajit/tree/skaplun/lj-1134-fix-link-nointegration
> Related issues:
> * https://github.com/tarantool/tarantool/issues/9595
> * https://github.com/LuaJIT/LuaJIT/issues/1134
>
>   test/tarantool-tests/lj-1134-hotside-jit-off.test.lua | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/tarantool-tests/lj-1134-hotside-jit-off.test.lua b/test/tarantool-tests/lj-1134-hotside-jit-off.test.lua
> index 080b1e87..27a778bc 100644
> --- a/test/tarantool-tests/lj-1134-hotside-jit-off.test.lua
> +++ b/test/tarantool-tests/lj-1134-hotside-jit-off.test.lua
> @@ -2,7 +2,7 @@ local tap = require('tap')
>   
>   -- Test file to demonstrate the JIT misbehaviour, when the side
>   -- trace is compiled after `jit.off()`.
> --- See also: https://github.com/LuaJIT/LuaJIT/issue/1134.
> +-- See also: https://github.com/LuaJIT/LuaJIT/issues/1134.
>   
>   local test = tap.test('lj-1134-hotside-jit-off'):skipcond({
>     ['Test requires JIT enabled'] = not jit.status(),

  parent reply	other threads:[~2024-03-26 14:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-20  7:19 Sergey Kaplun via Tarantool-patches
2024-03-20  8:57 ` Maxim Kokryashkin via Tarantool-patches
2024-03-26 14:12 ` Sergey Bronnikov via Tarantool-patches [this message]
2024-04-11 17:03 ` Sergey Kaplun via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fce4c390-634d-467b-849c-46c46060b10f@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=m.kokryashkin@tarantool.org \
    --cc=sergeyb@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit] test: fix typo in the link to the issue' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox