From: Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: tarantool-patches@dev.tarantool.org, skaplun@tarantool.org, sergeyb@tarantool.org Subject: [Tarantool-patches] [PATCH luajit 2/2 v8] test: don't skip tool CLI flag for tarantool Date: Fri, 25 Aug 2023 12:14:46 +0300 [thread overview] Message-ID: <fc67651d7a39ba9bff66404095088ff126314aba.1692954427.git.m.kokryashkin@tarantool.org> (raw) In-Reply-To: <cover.1692954427.git.m.kokryashkin@tarantool.org> That skipcond was introduced to overcome the obstacles of LuaJIT's integrational testing in Tarantool. Since the required patch is now in the Tarantool master, this skipcond is now unnecessary. Related to tarantool/tarantool#5688 --- test/tarantool-tests/gh-5688-tool-cli-flag.test.lua | 3 --- 1 file changed, 3 deletions(-) diff --git a/test/tarantool-tests/gh-5688-tool-cli-flag.test.lua b/test/tarantool-tests/gh-5688-tool-cli-flag.test.lua index b91902fd..33627ee2 100644 --- a/test/tarantool-tests/gh-5688-tool-cli-flag.test.lua +++ b/test/tarantool-tests/gh-5688-tool-cli-flag.test.lua @@ -3,9 +3,6 @@ local test = tap.test('gh-5688-tool-cli-flag'):skipcond({ ['Profile tools are implemented for x86_64 only'] = jit.arch ~= 'x86' and jit.arch ~= 'x64', ['Profile tools are implemented for Linux only'] = jit.os ~= 'Linux', - -- XXX: Tarantool integration is required to run this test properly. - -- luacheck: no global - ['No profile tools CLI option integration'] = _TARANTOOL, }) test:plan(3) -- 2.41.0
next prev parent reply other threads:[~2023-08-25 9:15 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-08-25 9:14 [Tarantool-patches] [PATCH luajit 0/2 v8] introduce cli for tools Maxim Kokryashkin via Tarantool-patches 2023-08-25 9:14 ` [Tarantool-patches] [PATCH luajit 1/2 v8] tools: add cli flag to run profile dump parsers Maxim Kokryashkin via Tarantool-patches 2023-08-28 11:17 ` Sergey Kaplun via Tarantool-patches 2023-08-25 9:14 ` Maxim Kokryashkin via Tarantool-patches [this message] 2023-08-28 11:21 ` [Tarantool-patches] [PATCH luajit 2/2 v8] test: don't skip tool CLI flag for tarantool Sergey Kaplun via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=fc67651d7a39ba9bff66404095088ff126314aba.1692954427.git.m.kokryashkin@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=max.kokryashkin@gmail.com \ --cc=sergeyb@tarantool.org \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit 2/2 v8] test: don'\''t skip tool CLI flag for tarantool' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox