From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id CBC7C6EC55; Thu, 26 Aug 2021 23:51:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CBC7C6EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1630011070; bh=cggG0T2lNLYv/ZT9FgG89DL3oxizjesRfktrcDxCEiE=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=Dh3sqS50UpDR88DFrK8MwajBTzIHgFJ/1Fr3pnozrPnRTMQeJBx4Enj2qqUMW0U1P cZYxA30UsnFFJM6PFy8NPgF5Yh9tdkiiMKHvAsvaDGGUOuUZ29HK53tw3Dg9oL16p3 RTNx9o8t9Yzci8BCHJspfwhSvLmzBmqsrPk5+rCE= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1B42A6EC55 for ; Thu, 26 Aug 2021 23:51:09 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1B42A6EC55 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1mJML6-0000i5-Hn; Thu, 26 Aug 2021 23:51:08 +0300 To: imeevma@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: <1d3ddbfe02f20123aada9b0e252368310f742bf0.1629989915.git.imeevma@gmail.com> Message-ID: Date: Thu, 26 Aug 2021 22:51:07 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <1d3ddbfe02f20123aada9b0e252368310f742bf0.1629989915.git.imeevma@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92087353F0EC44DD9736CF3E71F18CE0C3E1D5927724F4AAA182A05F5380850404B2A6BD3D42778A84FFBBC60AB885B0CADC45359E0CCFCF59D9BC54227CACC63 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7178CF5C0F418A002EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006374F897F3E43A934888638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D883415BC6B1747163C3A5418067A0F07D117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC3733B5EC72352B9FA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520B1593CA6EC85F86DC26CFBAC0749D213D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6A45692FFBBD75A6A089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B5058DF26E08643F150CF7F281CC614DD2F4 X-C1DE0DAB: 0D63561A33F958A5FF5B35FB98EF07D81ABB9CE1C0B6DEBF4DF6345C425D6FFFD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA756665624D6DDF07B5410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34B8CF715B894FC7114EAF7150A09E155E1864BACA8E39FAD53990714ED9C12CB5BA8D60346F081F9C1D7E09C32AA3244C9189F5787B40073654AAA5E88D47E59C4DBEAD0ED6C55A80729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj+bzRAXO2P1R+Mw8jR7jJoA== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D374746CAD2FC291A17F3C543D0F09AFE3841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 1/1] sql: allow to bind DECIMAL values X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the patch! See 3 comments below. > diff --git a/changelogs/unreleased/gh-4717-binding-for-decimal.md b/changelogs/unreleased/gh-4717-binding-for-decimal.md > new file mode 100644 > index 000000000..9ffd64272 > --- /dev/null > +++ b/changelogs/unreleased/gh-4717-binding-for-decimal.md > @@ -0,0 +1,4 @@ > +## feature/sql > + > +* Now DECIMAL values can be binded in SQL (gh-4717). 1. binded -> bound. > diff --git a/src/box/bind.h b/src/box/bind.h > index 143f010ce..a88cc105b 100644 > --- a/src/box/bind.h > +++ b/src/box/bind.h > @@ -40,6 +40,7 @@ extern "C" { > #include > > #include "msgpuck.h" > +#include "lua/decimal.h" 2. Why do you need Lua in the non-Lua folder? > #include "uuid/tt_uuid.h" > #include "mp_extension_types.h" > > diff --git a/src/box/sql/sqlInt.h b/src/box/sql/sqlInt.h > index d78076868..5d622bfad 100644 > --- a/src/box/sql/sqlInt.h > +++ b/src/box/sql/sqlInt.h > @@ -75,6 +75,7 @@ > #include "box/sql.h" > #include "box/txn.h" > #include "trivia/util.h" > +#include "lua/decimal.h" 3. Ditto.