Re: [Tarantool-patches] [PATCH v1 1/1] sql: allow to bind DECIMAL values

[Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Thanks for the patch!

See 3 comments below.

> diff --git a/changelogs/unreleased/gh-4717-binding-for-decimal.md b/changelogs/unreleased/gh-4717-binding-for-decimal.md
> new file mode 100644
> index 000000000..9ffd64272
> --- /dev/null
> +++ b/changelogs/unreleased/gh-4717-binding-for-decimal.md
> @@ -0,0 +1,4 @@
> +## feature/sql
> +
> +* Now DECIMAL values can be binded in SQL (gh-4717).

1. binded -> bound.

> diff --git a/src/box/bind.h b/src/box/bind.h
> index 143f010ce..a88cc105b 100644
> --- a/src/box/bind.h
> +++ b/src/box/bind.h
> @@ -40,6 +40,7 @@ extern "C" {
>  #include <stdlib.h>
>  
>  #include "msgpuck.h"
> +#include "lua/decimal.h"

2. Why do you need Lua in the non-Lua folder?

>  #include "uuid/tt_uuid.h"
>  #include "mp_extension_types.h"
>  
> diff --git a/src/box/sql/sqlInt.h b/src/box/sql/sqlInt.h
> index d78076868..5d622bfad 100644
> --- a/src/box/sql/sqlInt.h
> +++ b/src/box/sql/sqlInt.h
> @@ -75,6 +75,7 @@
>  #include "box/sql.h"
>  #include "box/txn.h"
>  #include "trivia/util.h"
> +#include "lua/decimal.h"

3. Ditto.