From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [217.69.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4BDA0446440 for ; Wed, 23 Sep 2020 04:40:39 +0300 (MSK) From: Alexander Turenko Date: Wed, 23 Sep 2020 04:40:22 +0300 Message-Id: In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Tarantool-patches] [PATCH 1.10 09/16] WIP: refactoring: add API_EXPORT to key_def functions List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org, Alexander Turenko It is the rule of thumb to use API_EXPORT with module API functions. To be honest, I don't see strict reason to use this macro except for unification with other module API functions. It adds 'extern', which is default for functions. It adds __attribute__((visibility("default"))), but symbols to be exported are listed in extra/exports or src/export.h (depending of tarantool version, see [1]). It adds __attribute__((nothrow)), which maybe allows a compiler to produce more optimized code and also catch an obvious problem and emit a warning. I don't know. So the reason for me is unification. Part of #5273 [1]: 2.5.0-42-g03790ac55 ('cmake: remove dynamic-list linker option') [2]: 1.6.8-71-g55605c5c9 ('Add __attribute__((nothrow)) to API_EXPORT macro') (cherry picked from commit 87223d32305b6c803c48f22a2319bffa90a64e4a) --- src/box/key_def.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/box/key_def.h b/src/box/key_def.h index 36d0b86d4..7623f650d 100644 --- a/src/box/key_def.h +++ b/src/box/key_def.h @@ -182,7 +182,7 @@ typedef struct key_def box_key_def_t; * \param part_count the number of key fields * \returns a new key definition object */ -box_key_def_t * +API_EXPORT box_key_def_t * box_key_def_new(uint32_t *fields, uint32_t *types, uint32_t part_count); /** @@ -190,7 +190,7 @@ box_key_def_new(uint32_t *fields, uint32_t *types, uint32_t part_count); * * \param key_def key definition to delete */ -void +API_EXPORT void box_key_def_delete(box_key_def_t *key_def); /** @@ -202,7 +202,7 @@ box_key_def_delete(box_key_def_t *key_def); * @retval <0 if key_fields(tuple_a) < key_fields(tuple_b) * @retval >0 if key_fields(tuple_a) > key_fields(tuple_b) */ -int +API_EXPORT int box_tuple_compare(const box_tuple_t *tuple_a, const box_tuple_t *tuple_b, box_key_def_t *key_def); @@ -217,7 +217,7 @@ box_tuple_compare(const box_tuple_t *tuple_a, const box_tuple_t *tuple_b, * @retval >0 if key_fields(tuple) > parts(key) */ -int +API_EXPORT int box_tuple_compare_with_key(const box_tuple_t *tuple_a, const char *key_b, box_key_def_t *key_def); -- 2.25.0