From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 827A9BA2F18; Thu, 13 Jun 2024 17:58:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 827A9BA2F18 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1718290710; bh=kvQvBU1eNjqX/vdrG5DGqLbdQjzscIPynR0i3r8/qXw=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=sbZL7cet1EiUBgyQ5CTaHRooBTinCf/eO8q/zkpxE4H0uvbTpSVsTuVpzKHhqS6Pa ysdvyvqHUjiEMlubc7PDVNRY3VkThUV41+J1Rdo9LELhNik6bHUvqkzda7qZtGDXQK n/ynEgWITt5GYhnGstsgJuUWGxTCskhTTkLgG/fE= Received: from smtp57.i.mail.ru (smtp57.i.mail.ru [95.163.41.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 42BFFBA2F18 for ; Thu, 13 Jun 2024 17:58:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 42BFFBA2F18 Received: by smtp57.i.mail.ru with esmtpa (envelope-from ) id 1sHluE-0000000CsXO-1TEj; Thu, 13 Jun 2024 17:58:26 +0300 Content-Type: multipart/alternative; boundary="------------5EH99kw1Dj040WXvJafqmB3a" Message-ID: Date: Thu, 13 Jun 2024 17:58:26 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun References: In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9923B2AA154DF63C69F83E24FDF70A404D569FCF785121A5C1313CFAB8367EF908E2BE116634AD74D86B0A756153AFF9D58653FEF3DE22B240B5305E1A53D9F4680C2D318ED1E5ED7A43962510F43F2FA X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7FBCED7D376B82B5EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006378A9F193E39E334918638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8B1B97452C98883753A415803B250607F646C002339C185DECC7F00164DA146DAFE8445B8C89999728AA50765F79006374F09588CB15B21E6389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC817119E5299B287EEF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947CAD0E433DBF1FBFA303F1AB874ED890284AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C3A209735FEA2E573EBA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE7AEA1580DED4E70E3731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A5867484A6CDA6ACE75002B1117B3ED6966C445E58C545AD1F108A05421C070DB8823CB91A9FED034534781492E4B8EEAD003C2D46C52F18F2BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFE2EEBEC038568E6A4D9AE6539151751DF2E293EDEA7D518060C5E594DD18249F698455FC0CD9C18204A26A3878DC13300228198987743E91B0F58789A30F7EDA762015A6F8B66B4D5F4332CA8FE04980913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojP/c/PTD82AkCAuE8n6QBtg== X-Mailru-Sender: 520A125C2F17F0B1E52FEF5D219D614086B0A756153AFF9D58653FEF3DE22B2473438271E4E3F1A00152A3D17938EB451EB5A0BCEC6A560B3DDE9B364B0DF289BE2DA36745F2EEB5CEBA01FB949A1F1EEAB4BC95F72C04283CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v1 5/5] Use generic trace error for OOM during trace stitching. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------5EH99kw1Dj040WXvJafqmB3a Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey thanks for the answers. On 13.06.2024 13:31, Sergey Kaplun wrote: > +test:skipcond({ >>> + -- luacheck: no global >> I made a patch that remove inline suppressions [1]. >> >> I propose to merge it and remove inline suppressions in your patch >> series too. > Ok, I'll remove these supressions after merging your patch and rebasing > to the master. Okay! > > >>> >>> +-- We only need the abort reason in the test. >>> +jparse.start('t') >> Same comment as in previous mail - let's add a comment regarding 't'. > See my answers here [1]. Okay! > >>> + >>> -- XXX: Update hotcounts to avoid hash collisions. >>> jit.opt.start('hotloop=1') >>> - >>> jit.on() >>> >>> mockalloc.mock() >>> @@ -49,6 +58,28 @@ tracef() >>> >>> mockalloc.unmock() >> Same comment as in previous mail - let's avoid name 'mock' here. > But we actually mock the allocator here, don't we? > Thus, I renamed the new allocated function to avoid confusion. > If you insist, please suggest the correct name instead `mock` | > `unmock`. We can replace "mock"/"unmock" to "{enable, disable} error injection". Actually, I don't want to insist. I'm ok if it wouldn't confuse anyone. >>> > > >>> test:done(true) > [1]:https://lists.tarantool.org/pipermail/tarantool-patches/2024-June/029218.html > --------------5EH99kw1Dj040WXvJafqmB3a Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Sergey

thanks for the answers.

On 13.06.2024 13:31, Sergey Kaplun wrote:

<snipped>

+test:skipcond({ 
+  -- luacheck: no global

I made a patch that remove inline suppressions [1].

I propose to merge it and remove inline suppressions in your patch 
series too.

Ok, I'll remove these supressions after merging your patch and rebasing
to the master.
Okay!
<snipped>


  
+-- We only need the abort reason in the test.
+jparse.start('t')

Same comment as in previous mail - let's add a comment regarding 't'.

See my answers here [1].
Okay!


+
  -- XXX: Update hotcounts to avoid hash collisions.
  jit.opt.start('hotloop=1')
-
  jit.on()
  
  mockalloc.mock()
@@ -49,6 +58,28 @@ tracef()
  
  mockalloc.unmock()

Same comment as in previous mail - let's avoid name 'mock' here.

But we actually mock the allocator here, don't we?
Thus, I renamed the new allocated function to avoid confusion.
If you insist, please suggest the correct name instead `mock` |
`unmock`.

We can replace "mock"/"unmock" to "{enable, disable} error injection".

Actually, I don't want to insist. I'm ok if it wouldn't confuse anyone.


      

        

          
  


        

      

      
<snipped>



      

        

          
  test:done(true)


        

      

      
[1]: https://lists.tarantool.org/pipermail/tarantool-patches/2024-June/029218.html



    

  
  


--------------5EH99kw1Dj040WXvJafqmB3a--