Hi, Sergey

thanks for the answers.

On 13.06.2024 13:31, Sergey Kaplun wrote:

<snipped>

+test:skipcond({
+  -- luacheck: no global
I made a patch that remove inline suppressions [1].

I propose to merge it and remove inline suppressions in your patch 
series too.
Ok, I'll remove these supressions after merging your patch and rebasing
to the master.
Okay!
<snipped>

  
+-- We only need the abort reason in the test.
+jparse.start('t')
Same comment as in previous mail - let's add a comment regarding 't'.
See my answers here [1].
Okay!

+
  -- XXX: Update hotcounts to avoid hash collisions.
  jit.opt.start('hotloop=1')
-
  jit.on()
  
  mockalloc.mock()
@@ -49,6 +58,28 @@ tracef()
  
  mockalloc.unmock()
Same comment as in previous mail - let's avoid name 'mock' here.
But we actually mock the allocator here, don't we?
Thus, I renamed the new allocated function to avoid confusion.
If you insist, please suggest the correct name instead `mock` |
`unmock`.

We can replace "mock"/"unmock" to "{enable, disable} error injection".

Actually, I don't want to insist. I'm ok if it wouldn't confuse anyone.


      
  
<snipped>

  test:done(true)
[1]: https://lists.tarantool.org/pipermail/tarantool-patches/2024-June/029218.html