From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 6CFC29D9B64; Wed, 7 Feb 2024 09:52:19 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6CFC29D9B64 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1707288739; bh=a546TQ5Sd6I1NVhpF7z2/XUDJ8eItjXvMg4klhBEcFY=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Rj+vpROB9PfpjBrw2bjuEdmXmr6ngPR0QwWaM9EDnGkhGDydbIWNvcpAV8/UO83eQ /lGCaas8l5jmU7777FttKALLh72uYOPxloO0UWxnlzKX09zTHcFpKYtFQY+rAiOW9D AxZJqZnSvo+tUz/aC3sT560IqdCOSbMGlArQrOAk= Received: from smtp46.i.mail.ru (smtp46.i.mail.ru [95.163.41.84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id BFD499D9B5E for ; Wed, 7 Feb 2024 09:52:17 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BFD499D9B5E Received: by smtp46.i.mail.ru with esmtpa (envelope-from ) id 1rXbn7-0000000FPRz-0T3c; Wed, 07 Feb 2024 09:52:17 +0300 Message-ID: Date: Wed, 7 Feb 2024 09:52:17 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun References: <6cda5e07-00a9-440d-a6e1-0044dda8f889@tarantool.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD94C460F083DF69F511846634448A0B09D48B4D6D920496B8E182A05F5380850400E19074C7B5173D4411046492FDDF806AA4362880B737E1E6D471AED9581EF332B3B62D25A8A63BE X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72E4E5201E1C2E308EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006378F586D843116CFB2EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38B73AB1701401CD8711ACAADEAF59157830D0F35D9D0F6A6EA7E2FDDB637267A04A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE77A825AB47F0FC8649FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C317B107DEF921CE79117882F4460429728AD0CFFFB425014E868A13BD56FB6657D81D268191BDAD3DC09775C1D3CA48CF9A1C9D3BA3303E89BA3038C0950A5D36C8A9BA7A39EFB766D91E3A1F190DE8FDBA3038C0950A5D36D5E8D9A59859A8B6BFC5BFC0DB013F7476E601842F6C81A1F004C906525384303E02D724532EE2C3F43C7A68FF6260569E8FC8737B5C22494854413538E1713FE827F84554CEF50127C277FBC8AE2E8BF1175FABE1C0F9B6AAAE862A0553A39223F8577A6DFFEA7CEB8BE9EE02D59E2D43847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A50D14B4F1955DC1BF5002B1117B3ED696830805B89E118CFDC89B063BDC7FAC35823CB91A9FED034534781492E4B8EEAD329DC2EF12373DEABDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34BD150993ED26DDF405B654EADBA1180E73781128EFD08ACBAB48A37D7850FA7A048745A1829379241D7E09C32AA3244C0779EA7FC68C94607215182CA7F28860CE2AE8D2B28B2BEDEA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59978A700BF655EAEEED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojh/iSjD2txnOIRvZWZAC9nA== X-Mailru-Sender: C4F68CFF4024C8867DFDF7C7F2588458989B7752BDE3CA2E601A8E04A89F3FFC6DF6D5B55AF59BC43CBDD1ECEAE11B08645D15D82EE4B272BD6E4642A116CA93524AA66B5ACBE6721EF430B9A63E2A504198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 08/26] test: enable in LuaJIT-tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey thanks for fixes. LGTM On 2/6/24 15:10, Sergey Kaplun wrote: > Hi, Sergey! > Thanks for the review! > Fixed your comments and force-pushed the branch. > > On 01.02.24, Sergey Bronnikov wrote: >> Hi, Sergey >> >> thanks for the patch! LGTM with a minor comment below >> >> On 1/29/24 13:45, Sergey Kaplun wrote: >>> This patch changes the `dofile()` (which uses an unreliable relative >>> file path and mutates `_G` with global functions to be defined) to the >>> corresponding `require()`. Also, it names the only one test as "misc" >> extra whitespace before "Also" > Fixed, thanks! > >>> and includes the test in . >>> >>> Part of tarantool/tarantool#9398 >>> --- > The new commit message is the following: > > | test: enable in LuaJIT-tests > | > | This patch changes the `dofile()` (which uses an unreliable relative > | file path and mutates `_G` with global functions to be defined) to the > | corresponding `require()`. Also, it splits the test case into several > | and includes the test in . > | > | Part of tarantool/tarantool#9398 >