From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp17.mail.ru (smtp17.mail.ru [94.100.176.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 76C5F45C304 for ; Wed, 2 Dec 2020 13:49:41 +0300 (MSK) References: <20201116164006.fw3jwes4dwbx7nsd@tkn_work_nb> <8365255bb9eef01293f66d9a7293730fecc49e2b.1605691680.git.sergeyb@tarantool.org> <20201127014528.v4ivfv7akgdxak5j@tkn_work_nb> <68835173-98b8-60ce-4ea5-ae427c530db3@tarantool.org> <20201202034003.mezalnkxy3pwyecp@tkn_work_nb> From: Sergey Bronnikov Message-ID: Date: Wed, 2 Dec 2020 13:49:39 +0300 MIME-Version: 1.0 In-Reply-To: <20201202034003.mezalnkxy3pwyecp@tkn_work_nb> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [Tarantool-patches] [PATCH] Add options for upgrade testing List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Turenko Cc: Mons Anderson , tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy On 02.12.2020 06:40, Alexander Turenko wrote: > I'm okay with the state on the branch [3] (it is updated as shown above) > and I ready to push it if you don't have objections against the result > of squashing. I included my variant of extract_schema_from_snapshot() > (but it leans on PATH, it is enough for usages from TarantoolServer). I have tested patches again and it seems it works as expected. Let's merge patches to master. > > I performed the following tests using tarantool 2.7.0-73-gb53cb2aec > repository (debug build). > > 0. make lint > No errors / warnings. Okay. > > 1. An app test. > | (cd test && ./test-run.py box-tap/merger.test.lua) > Passed. Okay. > > 2. An app test. Snapshot from 1.10. > | (cd test && ./test-run.py \ > | --snapshot ../../../1.10/00000000000000000000.snap \ > | box-tap/merger.test.lua) > Passed. Upgrade entries are present in the log. Okay. > > 3. An app test. Snapshot from 1.10. No schema upgrade. > | (cd test && ./test-run.py \ > | --snapshot ../../../1.10/00000000000000000000.snap \ > | box-tap/merger.test.lua --disable-schema-upgrade) > Passed. No upgrade entries in the log. Okay. > > 4. A tarantool test. > | (cd test && ./test-run.py box/net.box_timeout_gh-1533.test.lua) > Passed. Okay. > > 5. A tarantool test. Snapshot from 1.10. > | (cd test && ./test-run.py \ > | --snapshot ../../../1.10/00000000000000000000.snap \ > | box/net.box_timeout_gh-1533.test.lua) > Passed. Upgrade entries are present in the log. Okay. > > 6. A tarantool test. Snapshot from 1.10. No schema upgrade. > | (cd test && ./test-run.py \ > | --snapshot ../../../1.10/00000000000000000000.snap \ > | box/net.box_timeout_gh-1533.test.lua --disable-schema-upgrade) > Passed. No upgrade entries in the log. Okay. > > 7. --disable-schema-upgrade without --snapshot. > | (cd test && ./test-run.py --disable-schema-upgrade) > Gives an error. Okay. > > 8. Conflicting options. > | (cd test && ./test-run.py --gdb --valgrind) > Gives an error. Okay. > > 9. Run the whole test suite. > | (cd test && ./test-run.py --long --force) > Passed except replication/election_qsync_stress.test.lua, which is > known as flaky on this revision. Okay. > > Rebuilt the same tarantool revision as RelWithDebInfo and performed the > following test: > > 10. Attempt to use --disable-schema-upgrade on a RelWithDebInfo build. > | (cd test && ./test-run.py \ > | --snapshot ../../../1.10/00000000000000000000.snap \ > | box/net.box_timeout_gh-1533.test.lua --disable-schema-upgrade) > Gives an error. Okay. > > I rewrote my 'snapshot mangling' patches to introduce the new > --bootstrap option and pushed them to the branch [4]. I propose to don't > push them to master at least until we'll found them useful. > > [1]: https://github.com/tarantool/tarantool/issues/5540 > [2]: https://github.com/tarantool/tarantool/issues/4801 > [3]: ligurio/gh-4801-add-snapshot-option > [4]: Totktonada/gh-4801-add-bootstrap-option