From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 8D30A217F7
	for <tarantool-patches@freelists.org>; Sat, 29 Dec 2018 12:42:33 -0500 (EST)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id fRHvXrbuOW6e for <tarantool-patches@freelists.org>;
	Sat, 29 Dec 2018 12:42:33 -0500 (EST)
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 4C6EB21227
	for <tarantool-patches@freelists.org>; Sat, 29 Dec 2018 12:42:33 -0500 (EST)
Subject: [tarantool-patches] Re: [PATCH 1/8] sql: remove
 SQLITE_ENABLE_UPDATE_DELETE_LIMIT define
References: <cover.1545987214.git.korablev@tarantool.org>
 <628c1d80ee13227d3e3d520707c3d404346fc94f.1545987214.git.korablev@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <fa86d688-fbc2-3f6f-7bbe-d7b90ad18e06@tarantool.org>
Date: Sat, 29 Dec 2018 20:42:31 +0300
MIME-Version: 1.0
In-Reply-To: <628c1d80ee13227d3e3d520707c3d404346fc94f.1545987214.git.korablev@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org, Nikita Pettik <korablev@tarantool.org>

Hi! Thanks for the patch!

SQLITE_ENABLE_UPDATE_DELETE_LIMIT still exists
in sql-tap/e_delete.test.lua.

I found out that in this file all tests from line 111
to line 495 are about DELETE LIMIT, so we can remove
them as well, can't we?

On 28/12/2018 12:34, Nikita Pettik wrote:
> Code under this define is dead. What is more, it uses affinity, so lets
> remove it.
> 
> Needed for #3698
> ---
>   src/box/sql/parse.y   |  2 --
>   src/box/sql/resolve.c | 20 --------------------
>   2 files changed, 22 deletions(-)
>