From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id A4353401A41
 for <tarantool-patches@dev.tarantool.org>;
 Sat, 26 Oct 2019 20:30:13 +0300 (MSK)
References: <cover.1572014705.git.imeevma@gmail.com>
 <74ad080dfda5faf647366f8c358603432c4284b4.1572014706.git.imeevma@gmail.com>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <fa5671d0-7f93-5296-a619-731ba35a1bf7@tarantool.org>
Date: Sat, 26 Oct 2019 19:35:37 +0200
MIME-Version: 1.0
In-Reply-To: <74ad080dfda5faf647366f8c358603432c4284b4.1572014706.git.imeevma@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v2 4/5] temporary: disable
	boolean.test.sql
List-Id: Tarantool development <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: imeevma@tarantool.org
Cc: tarantool-patches@freelists.org, tarantool-patches@dev.tarantool.org

Thanks for the patch!

On 25/10/2019 17:45, imeevma@tarantool.org wrote:
> Since PRAGMA 'sql_default_engine' will be removed in the next
> patch, this test will fail until test-run is fixed.
> 
> This patch should be removed before patch-set will be pushed.

Not sure if I understand. Does the next patch break this
test? If so, why does not it fix the test?

> ---
>  test/sql/suite.ini | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/test/sql/suite.ini b/test/sql/suite.ini
> index a8664c5..a2573be 100644
> --- a/test/sql/suite.ini
> +++ b/test/sql/suite.ini
> @@ -8,7 +8,7 @@ config = engine.cfg
>  is_parallel = True
>  lua_libs = lua/sql_tokenizer.lua
>  release_disabled = errinj.test.lua view_delayed_wal.test.lua sql-debug.test.lua
> -disabled = sql-statN-index-drop.test.lua
> +disabled = sql-statN-index-drop.test.lua boolean.test.sql
>  pretest_clean = True
>  fragile = dll.test.lua           ; gh-4427
>            func-recreate.test.lua ; gh-4384
>