From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 05BBD16EC054; Fri, 2 Jan 2026 18:58:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 05BBD16EC054 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1767369519; bh=PhiKmgGxD2vkjWgJjgWpl0nBIBBu2yDd7qeFQYO4TBI=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=I8mOSQ9dwVLDhS37UylUODCgpM7lNdHdbK5r0SGtCsNOzQZTk5ZcoyFTnKfSig2QI C/2dGVo8mqQpu6SbyizVGT5G2OcwG90ZQIzV8PIhNYumst96O4pQAipcVU6Gnfay5H AxUt3jCw6sbUjx7ttJ4Fevz2eb8mnrD8V0r+HyKc= Received: from send218.i.mail.ru (send218.i.mail.ru [95.163.59.57]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7A69416EC052 for ; Fri, 2 Jan 2026 18:58:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7A69416EC052 Received: by exim-smtp-7b4fb89df9-pbtpt with esmtpa (envelope-from ) id 1vbhXx-00000000Frl-2mWb; Fri, 02 Jan 2026 18:58:37 +0300 Content-Type: multipart/alternative; boundary="------------R9pGZGb9p8AiKvQ6Li0s0g3q" Message-ID: Date: Fri, 2 Jan 2026 18:58:37 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD979975AF0D777FEBD136B1DE29D0A141801E96C80D96E6DBF182A05F5380850400BD15352EA6762103DE06ABAFEAF6705D0EA70B3F204D90B7ACA87A2557ADB158E62883BDF625A9B X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE776377A057133B646EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006377E85B0EC44E8FD73EA1F7E6F0F101C67CDEEF6D7F21E0D1D9295C2E9FA3191EE1B59CA4C82EFA6580294ECA7E1EB338F4F73D3233A2A14BEF700DC6478A9F9E0117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF1175FABE1C0F9B6A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD182CC0D3CB04F14752D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE9647ADFADE5905B1FCB1554B277F7060D8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE3AD0E433DBF1FBFA303F1AB874ED89028C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F79006372A310894EFA5E9A9EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5B4955E73395416AF5002B1117B3ED696BDCB577906B4A463361FAC1196A180DE823CB91A9FED034534781492E4B8EEAD220496FFA5CD4785BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D659479DBF36810689273968A200EBA214B4F2D8488EE02EF5C45A9458145D3D065BE88E10EF603A1C9BB8341EE9D5BE9A0A38F56358B15BFED1D1C81B65E447F9ACA86A44B46A86F53D8CD93680B12512CF4C41F94D744909CE2512F26BEC029E55448553D2254B8D95CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVTZJppT4ZVHRHG3bK+/h70o= X-Mailru-Sender: C4F68CFF4024C8867DFDF7C7F2588458A79BEE4A1FA57920BC5A20191D90C84F1FD2F866FE0DE0C3584597AFD1D8DEFC645D15D82EE4B272BD6E4642A116CA93524AA66B5ACBE6721EF430B9A63E2A504198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 29/41] perf: adjust scimark-fft in LuaJIT-benches X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------R9pGZGb9p8AiKvQ6Li0s0g3q Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey, thanks for the patch! LGTM with a minor comment. Sergey On 12/26/25 12:18, Sergey Kaplun wrote: > This patch adjusts the aforementioned test to use the benchmark > framework introduced before. The default arguments are adjusted > according to the file. The arguments to the script still > can be provided in the command line run. > > Checks are omitted since they were not present in the original suite, > plus the precise result value depends on the input parameter. > --- > perf/LuaJIT-benches/scimark-fft.lua | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-) > > diff --git a/perf/LuaJIT-benches/scimark-fft.lua b/perf/LuaJIT-benches/scimark-fft.lua > index c05bb69a..96535774 100644 > --- a/perf/LuaJIT-benches/scimark-fft.lua > +++ b/perf/LuaJIT-benches/scimark-fft.lua > @@ -1 +1,18 @@ The small test description was not added. Is it intentional? > -require("scimark_lib").FFT(1024)(tonumber(arg and arg[1]) or 50000) > +local bench = require("bench").new(arg) > + > +local cycles = tonumber(arg and arg[1]) or 50000 > +local benchmark > +benchmark = { > + name = "scimark_fft", > + -- XXX: The description of tests for the function is too > + -- inconvenient. > + skip_check = true, > + payload = function() > + local flops = require("scimark_lib").FFT(1024)(cycles) > + benchmark.items = flops > + end, > +} > + > +bench:add(benchmark) > + > +bench:run_and_report() --------------R9pGZGb9p8AiKvQ6Li0s0g3q Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Sergey,

thanks for the patch! LGTM with a minor comment.

Sergey

On 12/26/25 12:18, Sergey Kaplun wrote:
This patch adjusts the aforementioned test to use the benchmark
framework introduced before. The default arguments are adjusted
according to the <PARAM_x86.txt> file. The arguments to the script still
can be provided in the command line run.

Checks are omitted since they were not present in the original suite,
plus the precise result value depends on the input parameter.
---
 perf/LuaJIT-benches/scimark-fft.lua | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/perf/LuaJIT-benches/scimark-fft.lua b/perf/LuaJIT-benches/scimark-fft.lua
index c05bb69a..96535774 100644
--- a/perf/LuaJIT-benches/scimark-fft.lua
+++ b/perf/LuaJIT-benches/scimark-fft.lua
@@ -1 +1,18 @@
The small test description was not added. Is it intentional? 
-require("scimark_lib").FFT(1024)(tonumber(arg and arg[1]) or 50000)
+local bench = require("bench").new(arg)
+
+local cycles = tonumber(arg and arg[1]) or 50000
+local benchmark
+benchmark = {
+  name = "scimark_fft",
+  -- XXX: The description of tests for the function is too
+  -- inconvenient.
+  skip_check = true,
+  payload = function()
+    local flops = require("scimark_lib").FFT(1024)(cycles)
+    benchmark.items = flops
+  end,
+}
+
+bench:add(benchmark)
+
+bench:run_and_report()
--------------R9pGZGb9p8AiKvQ6Li0s0g3q--