From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 7BA5F4765E0
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 23 Dec 2020 18:40:01 +0300 (MSK)
References: <cover.1608726409.git.estetus@gmail.com>
 <e5070e83623752680c056af6887d234188a461d0.1608726409.git.estetus@gmail.com>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <f96f5493-2f5e-54f9-94d0-8aaa22a3f407@tarantool.org>
Date: Wed, 23 Dec 2020 16:39:59 +0100
MIME-Version: 1.0
In-Reply-To: <e5070e83623752680c056af6887d234188a461d0.1608726409.git.estetus@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v3 1/5] test: convert print to
 function and make quotes use consistent
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: sergeyb@tarantool.org, tarantool-patches@dev.tarantool.org, lvasiliev@tarantool.org

Hi! Thanks for the patch!

> diff --git a/test/replication-py/swap.test.py b/test/replication-py/swap.test.py
> index 98eeeea6d..b162ae241 100644
> --- a/test/replication-py/swap.test.py
> +++ b/test/replication-py/swap.test.py
> @@ -7,26 +9,26 @@ import yaml
>  REPEAT = 20
>  ID_BEGIN = 0
>  ID_STEP = 5
> -LOGIN = 'test'
> -PASSWORD = 'pass123456'
> +LOGIN = "test"
> +PASSWORD = "pass123456"
>  
> -engines = ['memtx', 'vinyl']
> +engines = ["memtx", "vinyl"]
>  
>  def insert_tuples(_server, begin, end, msg = "tuple"):
>      for engine in engines:
>          for i in range(begin, end):
> -            print 'box.space.%s:insert{%d, "%s %d"}' % (engine, i, msg, i)
> -            print '-'
> +            print('box.space.{}:insert{{{}, "{} {}"}}'.format(engine, i, msg, i))

Oh, noooo! There is still ' instead of " !!!