From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id DD145D27795; Thu, 4 Jul 2024 17:59:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DD145D27795 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1720105177; bh=jhW3kyzyBrKYbHkWwECXvoXCaodpiijNabllP1oRBqM=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=AVJWNZ9dvdQ6zLv7w8OK9R1DDrWCjIbxAMkqi8Q2OQaFxRn1YyL8IlP4yNKt4I2Dz FRZs8pREBy26lwm39bUCfcTdnrQN8D/UGLfyKqD1jvSQy6yiMwamlH6e453cH9PCfb 5fLWVVV2zkaz8vXr67RkGAKQa90ZpBJU0+FzCWDM= Received: from smtp49.i.mail.ru (smtp49.i.mail.ru [95.163.41.91]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id AD3C1D27780 for ; Thu, 4 Jul 2024 17:59:35 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org AD3C1D27780 Received: by smtp49.i.mail.ru with esmtpa (envelope-from ) id 1sPNvq-0000000BEjN-3EbM; Thu, 04 Jul 2024 17:59:35 +0300 Content-Type: multipart/alternative; boundary="------------h5SPGOyEkKsBm7LEvbpZwNyo" Message-ID: Date: Thu, 4 Jul 2024 17:59:34 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun References: In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD98779A897EF6512F77A3F743E90123B00F36D5A9286A0EA32182A05F538085040FAC0A2F55A449F8633594132A326AF8B09B5267E59CAA2A93B62E1A1FFA979E0485234136DCFB6CD X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE743AE26858062A689EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637FD60A286D0BA57028638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8DE9B7EAB419C7329A0F239A548EA89796162D03B007D9010CC7F00164DA146DAFE8445B8C89999728AA50765F790063735D2385A5E2B3AC3389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC817119E5299B287EEF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C632EDEA9CD5989A36E0066C2D8992A164AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C310DA8F912E8A02C0BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE71F4E386938175FB9731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A5C60C3F5E29D95E4F5002B1117B3ED696DEF304ABEC5FEDD71BDDAE3D1EA49BEA823CB91A9FED034534781492E4B8EEAD3CCD70CEBBF18A22BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF0077ED2955DAD51D843F3490834CF3B04FEA7533445F30020529951C2A33640F3D7E4ABC8EFFEBBECABF58F1CDB0D7D12B0554B1F7FF1CFACB0CECB6FDAD0BB503ECFD8730BE42D55F4332CA8FE04980913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojxv0jG2S+cqd+8nbtj/InDg== X-Mailru-Sender: 520A125C2F17F0B1E52FEF5D219D614026ADF9BBD4F53F02B90718C72141FD4643C21819F2D63E740152A3D17938EB451EB5A0BCEC6A560B3DDE9B364B0DF289BE2DA36745F2EEB5CEBA01FB949A1F1EEAB4BC95F72C04283CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/2] Avoid negation of signed integers in C that may hold INT*_MIN. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------h5SPGOyEkKsBm7LEvbpZwNyo Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey, thanks! LGTM On 04.07.2024 11:40, Sergey Kaplun wrote: > Hi, Sergey! > Thanks for the review! > Fixed your comments rebased to the tarantool/master and force-pushed the > branch. > > On 04.07.24, Sergey Bronnikov wrote: >> Hi, Sergey, >> >> thanks for the patch! LGTM with nit below >> >> >> On 25.06.2024 18:54, Sergey Kaplun wrote: >>> From: Mike Pall > > >>> diff --git a/test/tarantool-tests/lj-928-int-min-negation.test.lua b/test/tarantool-tests/lj-928-int-min-negation.test.lua >>> new file mode 100644 >>> index 00000000..26f4ed8e >>> --- /dev/null >>> +++ b/test/tarantool-tests/lj-928-int-min-negation.test.lua >>> @@ -0,0 +1,121 @@ >>> +local tap = require('tap') >>> + >>> +-- Test file to demonstrate LuaJIT's UBSan failures during >>> +-- `INT*_MIN` negation. >>> +-- See also:https://github.com/LuaJIT/LuaJIT/issues/928. >>> + >>> +local test = tap.test('lj-928-int-min-negation.'):skipcond({ >> dot could be omitted in a test's name. > Fixed, thanks! > > =================================================================== > diff --git a/test/tarantool-tests/lj-928-int-min-negation.test.lua b/test/tarantool-tests/lj-928-int-min-negation.test.lua > index 982bba73..bdf7e4f0 100644 > --- a/test/tarantool-tests/lj-928-int-min-negation.test.lua > +++ b/test/tarantool-tests/lj-928-int-min-negation.test.lua > @@ -4,7 +4,7 @@ local tap = require('tap') > -- `INT*_MIN` negation. > -- See also:https://github.com/LuaJIT/LuaJIT/issues/928. > > -local test = tap.test('lj-928-int-min-negation.'):skipcond({ > +local test = tap.test('lj-928-int-min-negation'):skipcond({ > ['Test requires JIT enabled'] = not jit.status(), > }) > > =================================================================== > >> > > --------------h5SPGOyEkKsBm7LEvbpZwNyo Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Sergey,

thanks! LGTM

On 04.07.2024 11:40, Sergey Kaplun wrote:
Hi, Sergey!
Thanks for the review!
Fixed your comments rebased to the tarantool/master and force-pushed the
branch.

On 04.07.24, Sergey Bronnikov wrote:

Hi, Sergey,

thanks for the patch! LGTM with nit below


On 25.06.2024 18:54, Sergey Kaplun wrote:

From: Mike Pall <mike>

<snipped>


diff --git a/test/tarantool-tests/lj-928-int-min-negation.test.lua b/test/tarantool-tests/lj-928-int-min-negation.test.lua
new file mode 100644
index 00000000..26f4ed8e
--- /dev/null
+++ b/test/tarantool-tests/lj-928-int-min-negation.test.lua
@@ -0,0 +1,121 @@
+local tap = require('tap')
+
+-- Test file to demonstrate LuaJIT's UBSan failures during
+-- `INT*_MIN` negation.
+-- See also:https://github.com/LuaJIT/LuaJIT/issues/928.
+
+local test = tap.test('lj-928-int-min-negation.'):skipcond({

dot could be omitted in a test's name.

Fixed, thanks!

===================================================================
diff --git a/test/tarantool-tests/lj-928-int-min-negation.test.lua b/test/tarantool-tests/lj-928-int-min-negation.test.lua
index 982bba73..bdf7e4f0 100644
--- a/test/tarantool-tests/lj-928-int-min-negation.test.lua
+++ b/test/tarantool-tests/lj-928-int-min-negation.test.lua
@@ -4,7 +4,7 @@ local tap = require('tap')
 -- `INT*_MIN` negation.
 -- See also: https://github.com/LuaJIT/LuaJIT/issues/928.
 
-local test = tap.test('lj-928-int-min-negation.'):skipcond({
+local test = tap.test('lj-928-int-min-negation'):skipcond({
   ['Test requires JIT enabled'] = not jit.status(),
 })
 
===================================================================




<snipped>
--------------h5SPGOyEkKsBm7LEvbpZwNyo--