Hi, Sergey, thanks! LGTM On 04.07.2024 11:40, Sergey Kaplun wrote: > Hi, Sergey! > Thanks for the review! > Fixed your comments rebased to the tarantool/master and force-pushed the > branch. > > On 04.07.24, Sergey Bronnikov wrote: >> Hi, Sergey, >> >> thanks for the patch! LGTM with nit below >> >> >> On 25.06.2024 18:54, Sergey Kaplun wrote: >>> From: Mike Pall > > >>> diff --git a/test/tarantool-tests/lj-928-int-min-negation.test.lua b/test/tarantool-tests/lj-928-int-min-negation.test.lua >>> new file mode 100644 >>> index 00000000..26f4ed8e >>> --- /dev/null >>> +++ b/test/tarantool-tests/lj-928-int-min-negation.test.lua >>> @@ -0,0 +1,121 @@ >>> +local tap = require('tap') >>> + >>> +-- Test file to demonstrate LuaJIT's UBSan failures during >>> +-- `INT*_MIN` negation. >>> +-- See also:https://github.com/LuaJIT/LuaJIT/issues/928. >>> + >>> +local test = tap.test('lj-928-int-min-negation.'):skipcond({ >> dot could be omitted in a test's name. > Fixed, thanks! > > =================================================================== > diff --git a/test/tarantool-tests/lj-928-int-min-negation.test.lua b/test/tarantool-tests/lj-928-int-min-negation.test.lua > index 982bba73..bdf7e4f0 100644 > --- a/test/tarantool-tests/lj-928-int-min-negation.test.lua > +++ b/test/tarantool-tests/lj-928-int-min-negation.test.lua > @@ -4,7 +4,7 @@ local tap = require('tap') > -- `INT*_MIN` negation. > -- See also:https://github.com/LuaJIT/LuaJIT/issues/928. > > -local test = tap.test('lj-928-int-min-negation.'):skipcond({ > +local test = tap.test('lj-928-int-min-negation'):skipcond({ > ['Test requires JIT enabled'] = not jit.status(), > }) > > =================================================================== > >> > >