From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id B2CA726A0E for ; Wed, 14 Aug 2019 16:46:14 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Fi65P8yojvZo for ; Wed, 14 Aug 2019 16:46:14 -0400 (EDT) Received: from smtp40.i.mail.ru (smtp40.i.mail.ru [94.100.177.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 754BD26A05 for ; Wed, 14 Aug 2019 16:46:14 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH] sql: remove unused mask References: <20190802124629.54302-1-roman.habibov@tarantool.org> From: Vladislav Shpilevoy Message-ID: Date: Wed, 14 Aug 2019 22:48:57 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Roman Khabibov , tarantool-patches@freelists.org, Kirill Yukhin LGTM. On 14/08/2019 16:35, Roman Khabibov wrote: > Vlad, could you do a second review? > >> On Aug 9, 2019, at 18:46, n.pettik wrote: >> >> >> >>> On 2 Aug 2019, at 15:46, Roman Khabibov wrote: >>> >>> Field mask of "struct Keyword" is always set to one not null >>> macroses and used only once for checking that it isn't null. So, >>> the field should be removed. >>> >>> Closes #4155 >> >> I’ve fixed commit message and force pushed. >> >> sql: remove mask from struct Keyword >> >> Originally, mask in struct Keyword served to reduce set of reserved >> keywords for build-dependent features. For instance, it was allowed to >> disable triggers as a compilation option, and in this case TRIGGER >> wouldn't be reserved word. Nowadays, our build always comprises all >> features, so there's no need in this option anymore. Hence, we can >> remove mask alongside with related to it macros. >> >> Closes #4155 >> >> The rest is OK as obvious.