From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 18166469719
 for <tarantool-patches@dev.tarantool.org>;
 Tue,  6 Oct 2020 00:22:21 +0300 (MSK)
References: <20200911215115.6622-1-roman.habibov@tarantool.org>
 <20200911215115.6622-3-roman.habibov@tarantool.org>
 <36bb1beb-a59a-57d9-a1ef-c0ef5af49d35@tarantool.org>
 <F65D415F-203D-486C-A825-E0D11893EC6F@tarantool.org>
 <d8f137c3-ac15-1c02-7fbc-690aa1972e92@tarantool.org>
 <F1CE04A0-ACB8-4F11-91A9-2FE5CC2270E7@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <f8722e8a-0f7a-9d75-a423-76b0d8e6f5e1@tarantool.org>
Date: Mon, 5 Oct 2020 23:22:20 +0200
MIME-Version: 1.0
In-Reply-To: <F1CE04A0-ACB8-4F11-91A9-2FE5CC2270E7@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v4 2/6] sql: refactor
 create_table_def and parse
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Roman Khabibov <roman.habibov@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi! Thanks for the patch!

> diff --git a/src/box/sql/parse_def.h b/src/box/sql/parse_def.h
> index cb0ecd2fc..21829b6f0 100644
> --- a/src/box/sql/parse_def.h
> +++ b/src/box/sql/parse_def.h
> @@ -500,12 +505,12 @@ create_view_def_init(struct create_view_def *view_def, struct Token *name,
>  }
>  
>  static inline void
> -create_table_def_destroy(struct create_table_def *table_def)
> +create_fkeys_def_destroy(struct create_fkeys_def *fkeys_def)

Where is create_checks_def destroyed?