From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 996E2F19349; Tue, 28 Jan 2025 12:03:11 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 996E2F19349 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1738054991; bh=z0KVbdJ6yy16EIPIv2ZqGhgjl0HDot12i3S6zt/JX0g=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=cn+K3f1bSOIKwSUQM9JlY4cNDB3T485+UnEULR7S/g8Us0HtjYN4dJX3WqPe1/5oB 0fBJE7TwRpqDThZPsFvVnW/+a+rFRvg7NF88BExddrVTwPrn1C3wmSHtbtUX9CL+Y6 1Y/ez/cOlgb+3EUS60qZiyWWyjO2MTgeF/MdtcXE= Received: from send279.i.mail.ru (send279.i.mail.ru [95.163.59.118]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2300C506541 for ; Tue, 28 Jan 2025 12:03:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2300C506541 Received: by exim-smtp-5bf6658466-jljkp with esmtpa (envelope-from ) id 1tchUz-00000000DQ5-0HUe; Tue, 28 Jan 2025 12:03:09 +0300 Content-Type: multipart/alternative; boundary="------------1eYhTol2oef0dQE0LdeR3SeC" Message-ID: Date: Tue, 28 Jan 2025 12:03:08 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: <20250127101814.23617-1-skaplun@tarantool.org> Content-Language: en-US In-Reply-To: <20250127101814.23617-1-skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD968032E0F70FD1A0C60F6FD440B417CE79F8F92C26E7E7ED500894C459B0CD1B9116F55E9B46A5E91AC8EDD30083ED68E3D7A7D7FEEDCA4086886E619191B4EFF31E418E160CADA48 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE709CF9AF650BAB6C1EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637829D9538242026C38638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8F65765434003CF522D37918CDC6AD8AF48CF7634D49AED3ACC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F79006370277CA7F994D7EF5389733CBF5DBD5E9B5C8C57E37DE458BD9DD9810294C998ED8FC6C240DEA76428AA50765F790063757B87AC57C2BBA94D81D268191BDAD3DBD4B6F7A4D31EC0BE2F48590F00D11D6D81D268191BDAD3D78DA827A17800CE78B4E9CFC5B2B6A16EC76A7562686271ED91E3A1F190DE8FD2E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3A27B50A64E76B53235872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5336DA510A08A4D125002B1117B3ED696B7491F7B4FF22C9714DB8790748E3E77823CB91A9FED034534781492E4B8EEADAE4FDBF11360AC9BBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF4B3CD78752A019D9206530B4EB13566B1883E446C503C55BB351E53805BC998FFD9AF20B71F72F3A477492209842FC2B49F17D61353AA6FBDE209E6D0B837B951C84B71B0A737FCD111DC66A97D0BFE2913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojLyxKgEujxHiedQkNmA0xpQ== X-Mailru-Sender: C4F68CFF4024C8867DFDF7C7F25884587CE974A14C4FBC3504DE63E6493D460558D450231C7C7212175EF8E0F419D52C645D15D82EE4B272BD6E4642A116CA93524AA66B5ACBE6721EF430B9A63E2A504198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v3 luajit] Fix command-line argv handling. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------1eYhTol2oef0dQE0LdeR3SeC Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sergey, thanks for the patch! LGTM with a minor comment. Sergey On 27.01.2025 13:18, Sergey Kaplun wrote: > diff --git a/test/tarantool-c-tests/CMakeLists.txt b/test/tarantool-c-tests/CMakeLists.txt > index c4a402d0..c84c651d 100644 > --- a/test/tarantool-c-tests/CMakeLists.txt > +++ b/test/tarantool-c-tests/CMakeLists.txt > @@ -41,6 +41,14 @@ file(GLOB tests "${CMAKE_CURRENT_SOURCE_DIR}/*${CTEST_SRC_SUFFIX}") > foreach(test_source ${tests}) > # Get test name without suffix. Needed to set OUTPUT_NAME. > get_filename_component(exe ${test_source} NAME_WE) > + > + # Test requires static build, since it inspects internal > + # symbols. > + if(exe STREQUAL "gh-8594-sysprof-ffunc-crash" > + AND BUILDMODE STREQUAL "dynamic") please put AND to the previous line and fix indentation --------------1eYhTol2oef0dQE0LdeR3SeC Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Sergey,


thanks for the patch! LGTM with a minor comment.

Sergey

On 27.01.2025 13:18, Sergey Kaplun wrote:


<snipped>

diff --git a/test/tarantool-c-tests/CMakeLists.txt b/test/tarantool-c-tests/CMakeLists.txt
index c4a402d0..c84c651d 100644
--- a/test/tarantool-c-tests/CMakeLists.txt
+++ b/test/tarantool-c-tests/CMakeLists.txt
@@ -41,6 +41,14 @@ file(GLOB tests "${CMAKE_CURRENT_SOURCE_DIR}/*${CTEST_SRC_SUFFIX}")
 foreach(test_source ${tests})
   # Get test name without suffix. Needed to set OUTPUT_NAME.
   get_filename_component(exe ${test_source} NAME_WE)
+
+  # Test requires static build, since it inspects internal
+  # symbols.
+  if(exe STREQUAL "gh-8594-sysprof-ffunc-crash"
+      AND BUILDMODE STREQUAL "dynamic")
please put AND to the previous line and fix indentation

    

    <snipped>

  
  


--------------1eYhTol2oef0dQE0LdeR3SeC--