From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id DAFA92834F for ; Fri, 15 Feb 2019 15:44:28 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id s0iSDgbAwCTG for ; Fri, 15 Feb 2019 15:44:28 -0500 (EST) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 91AED282C1 for ; Fri, 15 Feb 2019 15:44:28 -0500 (EST) Subject: [tarantool-patches] Re: [PATCH v5 0/6] sql: set column types for EXPLAIN and PRAGMA References: From: Vladislav Shpilevoy Message-ID: Date: Fri, 15 Feb 2019 23:44:26 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: imeevma@tarantool.org, "tarantool-patches@freelists.org" , Kirill Yukhin LGTM. On 29/01/2019 15:29, imeevma@tarantool.org wrote: > This patch-set defines the types for the result columns of EXPLAIN > and PRAGMA commands. In addition, it fixes some problems of the > PRAGMA commands that have something to do with their result. > > https://github.com/tarantool/tarantool/issues/3832 > https://github.com/tarantool/tarantool/tree/imeevma/gh-3832-no-column-types > > Changes in fifth version: > - Couple of commit-messages were fixed. > > v1: > https://www.freelists.org/post/tarantool-patches/PATCH-v1-11-sql-set-column-types-for-EXPLAIN-and-PRAGMA > v2: > https://www.freelists.org/post/tarantool-patches/PATCH-v2-06-sql-set-column-types-for-EXPLAIN-and-PRAGMA > v3: > https://www.freelists.org/post/tarantool-patches/PATCH-v3-06-sql-set-column-types-for-EXPLAIN-and-PRAGMA > v4: > https://www.freelists.org/post/tarantool-patches/PATCH-v4-06-sql-set-column-types-for-EXPLAIN-and-PRAGMA > > > Mergen Imeev (6): > sql: remove unused macros from pragma.c and pragma.h > sql: fix "PRAGMA parser_trace" result > sql: Show currently set sql_default_engine > sql: fix "PRAGMA case_sensitive_like" result > sql: get results of PRAGMA statement in YAML format > sql: set column types for EXPLAIN and PRAGMA > > src/box/execute.c | 5 +- > src/box/sql/CMakeLists.txt | 2 - > src/box/sql/parse.y | 4 +- > src/box/sql/pragma.c | 195 ++++++++++---------------- > src/box/sql/pragma.h | 259 ++++++++++++++++++++++------------- > src/box/sql/prepare.c | 52 +++++-- > src/box/sql/select.c | 22 +-- > src/box/sql/sqliteInt.h | 22 +-- > src/box/sql/where.c | 46 +++---- > src/box/sql/whereInt.h | 4 +- > test/sql-tap/gh-2367-pragma.test.lua | 35 +++-- > test/sql/iproto.result | 69 ++++++++++ > test/sql/iproto.test.lua | 18 ++- > test/sql/misc.result | 17 +++ > test/sql/misc.test.lua | 10 ++ > test/sql/sql-debug.result | 53 +++++++ > test/sql/sql-debug.test.lua | 19 +++ > test/sql/suite.ini | 2 +- > 18 files changed, 530 insertions(+), 304 deletions(-) > create mode 100644 test/sql/sql-debug.result > create mode 100644 test/sql/sql-debug.test.lua > > -- > 2.7.4 >