From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id D0411C596AF; Fri, 23 Aug 2024 18:41:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D0411C596AF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1724427700; bh=Pr5rY77CMqMmDGH3kXZ4Gg7T4+koYijRCy7TlWXqUCI=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=eTtdMC+3a8q5QHzGO/x3zYumjDBYmlMUJ/OBPmpDtSCYEeFMJv1/0yIEN+n4dJXiL HJ5GCHrpCDz/PRRdgW1eAbfx4SmldprSmESkGiP9dUOccdENNTlDvRqqnS2rOtJpHD ArsGwne7ezZZ1Eyon55nHUD3Rm/tLVQaCgQ8JNRY= Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [95.163.41.90]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 957AEC596AC for ; Fri, 23 Aug 2024 18:41:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 957AEC596AC Received: by smtp53.i.mail.ru with esmtpa (envelope-from ) id 1shWPy-0000000AVo6-48OZ; Fri, 23 Aug 2024 18:41:39 +0300 Content-Type: multipart/alternative; boundary="------------Ebp0oOUbW50p9ysgDMogKPDj" Message-ID: Date: Fri, 23 Aug 2024 18:41:38 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun References: <1f20f349-f23d-4bdd-9227-c106bfa691f9@tarantool.org> In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD9A67092BE052B1D9EA61430DDA0B5420A52B39D973F530245182A05F5380850406BEA073F1371D684C591814E25D11F9FB4A7B931FDA1141202F1026AD89F940D7EDAE2B993BF3920 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE75DF2B1F23425CAE5EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063786F1F539FBE87B778638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8801D0541844A0C51C41061F96863AE0618365234AE46605BCC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F7900637CAEE156C82D3D7D9389733CBF5DBD5E9B5C8C57E37DE458BD9DD9810294C998ED8FC6C240DEA76428AA50765F7900637B1B4F45B440FB135D81D268191BDAD3DBD4B6F7A4D31EC0BE2F48590F00D11D6D81D268191BDAD3D78DA827A17800CE7448F442DC5F8C29BEC76A7562686271ED91E3A1F190DE8FD2E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3AA8C68A3574AB3B435872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5CBB283F71BEF6A665002B1117B3ED69640E7BF33A88872D05D145BB8EF0DE66B823CB91A9FED034534781492E4B8EEAD47A3109F1ACFD409BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34AC6E62257D6CD1C9335F3FE4536656FCD4D4FF168613DBFF31FF073783BD432E08B5B6BA4521B93C1D7E09C32AA3244CEBE5F16EE124A66EEBBA027F22CEDE666AD20E8E467FD173EA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59978A700BF655EAEEED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojPqZSx9J9Ex27nNwjqKZU4g== X-Mailru-Sender: 520A125C2F17F0B1E52FEF5D219D614079D8ABBA2D2B32A1B3484BDBBEAF68BAFC5D589CC6D417FE0152A3D17938EB451EB5A0BCEC6A560B3DDE9B364B0DF289BE2DA36745F2EEB5CEBA01FB949A1F1EEAB4BC95F72C04283CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 35/45] test: enable LuaJIT test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------Ebp0oOUbW50p9ysgDMogKPDj Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sergey, On 22.08.2024 17:36, Sergey Kaplun wrote: > Hi, Sergey! > Thanks for the review! > Please consider my answer below. > > On 22.08.24, Sergey Bronnikov wrote: >> Sergey, >> >> On 21.08.2024 11:58, Sergey Kaplun wrote: >>> This patch moves the aforementioned test from the to the >>> directory (with slightly renaming to be consistent with other names), >>> includes it in , and names the subtest. >>> >>> Part of tarantool/tarantool#9398 >>> --- >> thanks for the patch! LGTM with comment below. >>> test/LuaJIT-tests/lang/index | 1 + >>> test/LuaJIT-tests/lang/stackov_c.lua | 12 ++++++++++++ >> May be "stackoverflow_coro.lua"? > I suppose the main idea is the possible stack overflow in the C function > (more accurate built-in function) `unpack`. I prefer to leave the old > name to avoid confusion. > > LGTM as I said before. --------------Ebp0oOUbW50p9ysgDMogKPDj Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Sergey,

On 22.08.2024 17:36, Sergey Kaplun wrote:
Hi, Sergey!
Thanks for the review!
Please consider my answer below.

On 22.08.24, Sergey Bronnikov wrote:

Sergey,

On 21.08.2024 11:58, Sergey Kaplun wrote:

This patch moves the aforementioned test from the <misc> to the <lang/>
directory (with slightly renaming to be consistent with other names),
includes it in <index>, and names the subtest.

Part of tarantool/tarantool#9398
---

thanks for the patch! LGTM with comment below.

  test/LuaJIT-tests/lang/index         |  1 +
  test/LuaJIT-tests/lang/stackov_c.lua | 12 ++++++++++++

May be "stackoverflow_coro.lua"?

I suppose the main idea is the possible stack overflow in the C function
(more accurate built-in function) `unpack`. I prefer to leave the old
name to avoid confusion.

LGTM as I said before.


<snipped>
--------------Ebp0oOUbW50p9ysgDMogKPDj--