From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 81B922A353
	for <tarantool-patches@freelists.org>; Thu, 13 Sep 2018 02:13:14 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id YWFwM07yjCud for <tarantool-patches@freelists.org>;
	Thu, 13 Sep 2018 02:13:14 -0400 (EDT)
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id C19742A34A
	for <tarantool-patches@freelists.org>; Thu, 13 Sep 2018 02:13:13 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH v1 3/3] sql: dissallow bindings
 for DDL
References: <cover.1535730218.git.kshcherbatov@tarantool.org>
 <cover.1535730218.git.kshcherbatov@tarantool.org>
 <5049d3e7b70b7091c51ac99fc64f14a07c879c8a.1535730218.git.kshcherbatov@tarantool.org>
 <EDD77E8A-40A8-4417-8EFC-CE245976B3D8@tarantool.org>
 <105d3104-aa3e-4834-ea31-fca817bad47e@tarantool.org>
 <661DC330-826B-41DC-A729-BBA9677CAD06@tarantool.org>
 <cc3a12cd-b6c1-678a-88d1-cb657d1a0a77@tarantool.org>
 <119B9157-8352-4256-8160-427752400D3E@tarantool.org>
From: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Message-ID: <f7df5f44-01d0-7e24-4f80-ba9079ad7211@tarantool.org>
Date: Thu, 13 Sep 2018 09:13:11 +0300
MIME-Version: 1.0
In-Reply-To: <119B9157-8352-4256-8160-427752400D3E@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org, Kirill Yukhin <kyukhin@tarantool.org>

> -
> -
> 
> Noise diff.
Ok.

> You forgot to drop table t5.
It isn't required as this attempt to create t5 should fail that is a test scenario.

>  box.sql.execute("DROP TABLE t;")
> +
> +
> 
> One new line is redundant.
Ok.

> 
> The rest *obviously* LGTM.
Kirill, let's merge It.