From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 4DC752CCA2
	for <tarantool-patches@freelists.org>; Mon, 16 Apr 2018 06:08:01 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id XzLUkorrDk4n for <tarantool-patches@freelists.org>;
	Mon, 16 Apr 2018 06:08:01 -0400 (EDT)
Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [94.100.177.94])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 0BE0F2CB6C
	for <tarantool-patches@freelists.org>; Mon, 16 Apr 2018 06:08:00 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH v2 2/2] Fixed lost format on
 update and upsert operations.
References: <cover.1523031806.git.kshcherbatov@tarantool.org>
 <ae6f6cf2eaeb6598f20493e145ed006e89fb509e.1523031806.git.kshcherbatov@tarantool.org>
 <1f4e0a5e-30f2-f36a-3970-ec4eeb14a456@tarantool.org>
 <b7e44689-e8d5-73c2-2a81-baca72e8ab3d@tarantool.org>
 <4a4c5106-1d2d-553f-c8f1-5c031e91c9ac@tarantool.org>
 <f724f6b0-9b99-385c-5830-8037663c0c5b@tarantool.org>
 <b8687ad4-4d77-449b-08cb-1d63737d1ef2@tarantool.org>
 <8a909d97-3f64-207d-fe25-a4462f814d38@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <f7d3d235-dbd1-983b-f64d-ab688c49e122@tarantool.org>
Date: Mon, 16 Apr 2018 13:07:57 +0300
MIME-Version: 1.0
In-Reply-To: <8a909d97-3f64-207d-fe25-a4462f814d38@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>, tarantool-patches@freelists.org

Hello. Thanks for fixes. One more thing is left - please,
add tests on incorrect update and incorrect upsert, as I
asked you in two previous reviews.

And in tests you does not need to do insert + get. Insert returns
the tuple, so you can do t = s:insert(), t:update/upsert ...

On 16/04/2018 10:47, Kirill Shcherbatov wrote:
> I've fixed tests and wrong code style with tabs.
> 
>  From f9803f8d0b411abac02e35d5e4120ff0ce7e9341 Mon Sep 17 00:00:00 2001
> From: Kirill Shcherbatov <kshcherbatov@tarantool.org>
> Date: Mon, 16 Apr 2018 10:44:10 +0300
> Subject: [PATCH] Fixed tests and spaces
>