From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 49184469719 for ; Sat, 19 Sep 2020 01:21:49 +0300 (MSK) From: Vladislav Shpilevoy Date: Sat, 19 Sep 2020 00:21:47 +0200 Message-Id: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Tarantool-patches] [PATCH 1/1] tests: fix replication/prune.test.lua hang List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: tarantool-patches@dev.tarantool.org, avtikhon@tarantool.org The test tried to start a replica whose box.cfg would hang, with replication_connect_quorum = 0 to make it return immediately. But the quorum parameter was added and removed during work on 444213178c6260d6adfd640f7e4a0c5e6f8f2458 ("replication: do not register outgoing connections"). Instead, to start the replica without blocking on box.cfg it is necessary to pass 'wait=False' with the test_run:cmd('start server') command. Closes #5311 --- Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-5311-prune-hangs Issue: https://github.com/tarantool/tarantool/issues/5311 test/replication/prune.result | 2 +- test/replication/prune.test.lua | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/replication/prune.result b/test/replication/prune.result index 67fd62990..e25e9684e 100644 --- a/test/replication/prune.result +++ b/test/replication/prune.result @@ -137,7 +137,7 @@ test_run:cmd('stop server replica1') --- - true ... -test_run:cmd('start server replica1 with args="true 0"') +test_run:cmd('start server replica1 with args="true", wait=False') --- - true ... diff --git a/test/replication/prune.test.lua b/test/replication/prune.test.lua index ea8b0b3c3..68300b270 100644 --- a/test/replication/prune.test.lua +++ b/test/replication/prune.test.lua @@ -66,7 +66,7 @@ test_run:cmd('eval replica1 "box.info.replication[1].upstream.message"') -- restart replica and check that replica isn't able to join to cluster test_run:cmd('stop server replica1') -test_run:cmd('start server replica1 with args="true 0"') +test_run:cmd('start server replica1 with args="true", wait=False') test_run:cmd('switch replica1') test_run:wait_upstream(1, {message_re = "Can't subscribe non%-anonymous replica"}) test_run:cmd('switch default') -- 2.21.1 (Apple Git-122.3)