From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 52FC825C14
	for <tarantool-patches@freelists.org>; Tue, 19 Jun 2018 07:57:43 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id cGZ1bBY16pgZ for <tarantool-patches@freelists.org>;
	Tue, 19 Jun 2018 07:57:43 -0400 (EDT)
Received: from smtp60.i.mail.ru (smtp60.i.mail.ru [217.69.128.40])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 1265C258CE
	for <tarantool-patches@freelists.org>; Tue, 19 Jun 2018 07:57:43 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH 2/2] Complete module reload
References: <cover.1528566184.git.avkhatskevich@tarantool.org>
 <d132dfc18a98151b4d27f4017a7c3d5e54ece3a6.1528566184.git.avkhatskevich@tarantool.org>
 <991c6880-9d5e-3f51-9003-a095984dc30d@tarantool.org>
 <d542133d-b62e-0237-f062-5875fba5cbb4@tarantool.org>
 <18667cab-8501-a46d-8255-89abfcb2bf0c@tarantool.org>
 <c28e754e-2669-28db-2ee2-8df59cc5b5b2@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <f7672fd7-4706-b716-c8b0-4cffe93769be@tarantool.org>
Date: Tue, 19 Jun 2018 14:57:40 +0300
MIME-Version: 1.0
In-Reply-To: <c28e754e-2669-28db-2ee2-8df59cc5b5b2@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: Alex Khatskevich <avkhatskevich@tarantool.org>, tarantool-patches@freelists.org


>>> +M.discovery_f = discovery_f
>>> +M.failover_f = failover_f
>>
>> 9. Why did you move these lines?
>>
> Because M table should not be changed in case of
> `router_cfg(M.current_cfg)`
> failure

But now router_cfg on reload starts old M.failover_f and
old M.discovery_f, it is not? I think, that if cfg fails on
reload, then the caller should just return to the old
version.