From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 6CD6AF41CC0; Mon, 24 Feb 2025 18:27:45 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6CD6AF41CC0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1740410865; bh=hprRwv0bpg49P2wjkxk81b3xSA2GabDAfiqFmJ/H0Bs=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=jaidXWhtnjacofbT7Ohk1UmcRKj4SmM6sDdb/8qqpgjzXg8vvJVdSUknKDeqlm7Ws GZx783Zj4vcEnxuhk0xVDMRAEaKzlbwV+hxtjkRgC3wY2nFWkJUqX8IGNrQlZb0imK 5WQgrL/B4L9J5EKZ1hdhxBPIvuXNVCAgjA0M1di0= Received: from send149.i.mail.ru (send149.i.mail.ru [89.221.237.244]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C9781F41CC0 for ; Mon, 24 Feb 2025 18:27:43 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C9781F41CC0 Received: by exim-smtp-75f5fcb77d-rpnnn with esmtpa (envelope-from ) id 1tmaMw-000000005g0-305c; Mon, 24 Feb 2025 18:27:43 +0300 Content-Type: multipart/alternative; boundary="------------3EUTDkL7RnNs430vwSiNnXWS" Message-ID: Date: Mon, 24 Feb 2025 18:27:42 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Sergey Kaplun , Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org References: Content-Language: en-US In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD957BCB5CA1E0F722C41FD2B8ADD64EF212A10D2BA5A3912FB182A05F5380850405C0F085FE7BF372E3DE06ABAFEAF6705BE047439CADAD30F282B44C757F98A21A7427CD01E6BCEC9 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7C6068CE86C2B75F5EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063767500BC4578134A08638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D811D35ACEF01B2F6A618542A86B35FA42561EB880979C8083CC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F7900637F3E38EE449E3E2AE389733CBF5DBD5E9B5C8C57E37DE458BD9DD9810294C998ED8FC6C240DEA76428AA50765F7900637ECDFC016942B1861D81D268191BDAD3DBD4B6F7A4D31EC0BE2F48590F00D11D6D81D268191BDAD3D78DA827A17800CE7A5B33CC6BAF1AC41EC76A7562686271ED91E3A1F190DE8FD2E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3045DD857D6FE754135872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A54401933287E54C8C5002B1117B3ED696857543CC62CE61CAC89B063BDC7FAC35823CB91A9FED034534781492E4B8EEAD528DE7AA5F2BD788BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34CA9B3B5DE5D383E6D654780EFE5C279F904021ACC408190BF209779E055C5C4498AC5D37232BDF441D7E09C32AA3244C5C3C703E43642E2977DD89D51EBB7742F733D22C1CC5EF15EA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59978A700BF655EAEEED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVQQG/FugD0/CDw1Jj8aTL9o= X-Mailru-Sender: 520A125C2F17F0B1E52FEF5D219D6140F09285DFD07F145AD27678DDAA8063146ECCB33AA96F79710152A3D17938EB451EB5A0BCEC6A560B3DDE9B364B0DF289BE2DA36745F2EEB5CEBA01FB949A1F1EEAB4BC95F72C04283CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/8][v3] test: align test title with test filename X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------3EUTDkL7RnNs430vwSiNnXWS Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey, On 24.02.2025 12:40, Sergey Kaplun via Tarantool-patches wrote: > Hi, Sergey! > Thanks for the fixes! > LGTM, except a single nit regarding the commit message. > > On 20.02.25, Sergey Bronnikov wrote: >> The patch fixes TAP test title to make it aligned with test >> filename. Inconsistency introduced in commit >> efd7e1a67de24464e1e83793e16eac6df443e3c0 >> ("test: make skipcond helper more convenient"). > I am afraid that this naming was introduced in the first commit related > to the tests (sysprof and memprof). So we either should mention 2 > initial commits or just omit this part. > > > Sorry, it was really introduced earlier. Removed this sentence at all. --------------3EUTDkL7RnNs430vwSiNnXWS Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Sergey,

On 24.02.2025 12:40, Sergey Kaplun via Tarantool-patches wrote:
Hi, Sergey!
Thanks for the fixes!
LGTM, except a single nit regarding the commit message.

On 20.02.25, Sergey Bronnikov wrote:

The patch fixes TAP test title to make it aligned with test
filename. Inconsistency introduced in commit
efd7e1a67de24464e1e83793e16eac6df443e3c0
("test: make skipcond helper more convenient").

I am afraid that this naming was introduced in the first commit related
to the tests (sysprof and memprof). So we either should mention 2
initial commits or just omit this part.

<snipped>

Sorry, it was really introduced earlier.

Removed this sentence at all.

--------------3EUTDkL7RnNs430vwSiNnXWS--