From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [tarantool-patches] [PATCH] box: allow vinyl_memory set to 0 in config References: <20180704113634.71324-1-sergepetrenko@tarantool.org> <20180704120237.4zfmw3pzm24cdblk@esperanza> From: Sergey Petrenko Message-ID: Date: Wed, 4 Jul 2018 15:56:06 +0300 MIME-Version: 1.0 In-Reply-To: <20180704120237.4zfmw3pzm24cdblk@esperanza> Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: 8bit Content-Language: ru To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: 04.07.2018 15:02, Vladimir Davydov пишет: > On Wed, Jul 04, 2018 at 02:36:34PM +0300, Serge Petrenko wrote: >> In 1.9 it was possible to have a vinylless configuration with >> vinyl_memory=0, allow to do this in 1.10 by adjusting sanity >> checks for vinyl_memory and memtx_memory. Now banning only >> negative values. >> memtx_memory check was changed for consistency, trying to >> set memtx_memory to 0 fails anyways. >> >> Closes: #3468 >> --- >> https://github.com/tarantool/tarantool/compare/sergepetrenko/gh-3468-allow-0-vinyl-memory >> https://github.com/tarantool/tarantool/issues/3468 >> >> src/box/box.cc | 8 ++++---- >> test/box/cfg.result | 4 ++-- >> 2 files changed, 6 insertions(+), 6 deletions(-) > Please add a test case checking that box.cfg.vinyl_memory can actually > be set to 0. Other than that looks OK. Added a test case. Thankyou for the review.