From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 92C6324466 for ; Thu, 24 Jan 2019 09:52:20 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JcynzXNBoC35 for ; Thu, 24 Jan 2019 09:52:20 -0500 (EST) Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 4A7B323440 for ; Thu, 24 Jan 2019 09:52:20 -0500 (EST) Subject: [tarantool-patches] Re: [PATCH v4 1/6] sql: remove unused macros from pragma.c and pragma.h References: <28ff08bf9df3a3948fdc399f4801f01d170c52a5.1547899933.git.imeevma@gmail.com> <19958464-07A6-486E-9717-AE69E3BD4B43@tarantool.org> From: Imeev Mergen Message-ID: Date: Thu, 24 Jan 2019 17:52:17 +0300 MIME-Version: 1.0 In-Reply-To: <19958464-07A6-486E-9717-AE69E3BD4B43@tarantool.org> Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: "n.pettik" , tarantool-patches@freelists.org Hi! Thank you for review. On 1/20/19 3:16 AM, n.pettik wrote: >> commit 28ff08bf9df3a3948fdc399f4801f01d170c52a5 >> Author: Mergen Imeev >> Date: Wed Dec 12 21:58:54 2018 +0300 >> >> sql: remove unused macros from pragma.c and pragma.h >> >> Some macros in pragma.c and pragma.h are obsolete because the >> values they are checking are no longer used. Let's remove them. > In fact they are used, but their usage makes no sense. > Then LGTM. Fixed. New commit-message: commit 1f667d56f6684a5cb7030097a66c4ac8b46d36cc Author: Mergen Imeev Date:   Wed Dec 12 21:58:54 2018 +0300     sql: remove unused macros from pragma.c and pragma.h     Some macros in pragma.c and pragma.h are obsolete because the     values they are checking are no longer used or their usage makes     no sense. Let's remove them.